Review 11.5 Merged

73657[BUGFIX] Properly reset form renderable validators

waldhacker CR +2 V +2 Normal +76 −2 updated 02/24/22, 18:18

Commit message

Since form renderable validators are stored as SplObjectStorage
instances, it is currently impossible to properly reset those
validators, e.g. within a configured variant in the form configuration.
This is because detaching during a foreach over SplObjectStorage
instances updates the internal pointer. This leads to inconsistent
behavior in the foreach loop.

To come around this issue, a cloned SplObjectStorage is now used to
remove all currently registered validators, properly resetting all
validators for the form renderable. Additionally, this edge case is now
covered by a functional test case.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3