Review main Merged

73679[TASK] Allow extension scanner reporting for dirs outside typo3conf

Kevin Appelt CR +2 V +2 Easy +30 −15 updated 03/01/22, 07:42

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • Jan Helke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2429

Show 34 earlier messages
  1. Kevin Appelt uploaded patch set 1 02/23/22, 14:45

  2. Kevin Appelt marked it work in progress 02/23/22, 14:45

  3. core-ci voted on patch set 1 V -1 02/23/22, 14:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24111

  4. Kevin Appelt uploaded patch set 2 02/23/22, 14:58

  1. Mathias Brodala commented on patch set 2 02/23/22, 15:03

    UpgradeController.php:203

    Don't we need a break after this? The first non-framework package should be enough for this flag after all. Alternatively count() after an array_filter().
  2. Kevin Appelt marked it ready for review 02/23/22, 15:05

  3. core-ci voted on patch set 2 V +1 02/23/22, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24113

  4. Kevin Appelt uploaded patch set 3 02/23/22, 15:11

  5. Kevin Appelt commented on patch set 3 02/23/22, 15:11

    UpgradeController.php:203 Reply

    Done
  6. Mathias Brodala commented on patch set 3 CR +1 02/23/22, 15:11

    UpgradeController.php:203 Reply

    Done
  7. core-ci voted on patch set 3 V +1 02/23/22, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24115

  8. Stefan Bürk commented on patch set 3 02/23/22, 15:52

    UpgradeController.php:199

    I think non extension packages should be skipped, too. But maybe I'm wrong (not sure about that meta data - maybe Helmut or Simon can say here more about it).

    UpgradeController.php:633

    Same as above - think we should skip non extension packages. Do not make sense to use the scanner against any general composer packages. Or ?
  9. Kevin Appelt commented on patch set 3 02/23/22, 16:08

    UpgradeController.php:199 Reply

    Good point. I had !$package->getPackageMetaData()->isExtensionType() first, but this also matches the framework type. I guess (!$package->getPackageMetaData()->isExtensionType() || $package->getPackageMetaData()->isFrameworkType()) should do the job better. I will add another patchset.

    UpgradeController.php:633 Reply

    Good point. I had !$package->getPackageMetaData()->isExtensionType() first, but this also matches the framework type. I guess (!$package->getPackageMetaData()->isExtensionType() || $package->getPackageMetaData()->isFrameworkType()) should do the job better. I will add another patchset.
  10. Kevin Appelt uploaded patch set 4 02/23/22, 16:12

  11. core-ci voted on patch set 4 V +1 02/23/22, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24125

  12. Kevin Appelt commented on patch set 4 02/23/22, 19:38

    This might help reviewing this change: https://forge.typo3.org/issues/97008#note-5
  13. Simon Gilli commented on patch set 4 02/23/22, 19:59

    Thanks! Some minor stuff and questions...

    UpgradeController.php:196

    I'd prefer `hasExtensions` here

    ExtensionScanner.html:73

    I don't get why you remove the .filename here. Was this a bug?
  14. Kevin Appelt uploaded patch set 5 02/23/22, 20:38

  15. Kevin Appelt commented on patch set 5 02/23/22, 20:46

    UpgradeController.php:196 Reply

    Done

    ExtensionScanner.html:73 Reply

    {extensionScannerExtensionList} previously contained the data from the Finder and {extensionInTypo3conf} was in each case an object in which .filename contained for example 'styleguide'. By using the packageManager {extensionScannerExtensionList} now only contains an array of packages, so {extension} is already 'styleguide' without any other properties.
  16. core-ci voted on patch set 5 V +1 02/23/22, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24148

  17. Jan Helke voted on patch set 5 CR +1 02/23/22, 21:01

  18. Simon Gilli commented on patch set 5 02/24/22, 14:04

    ExtensionScanner.html:73 Reply

    Thanks, got it now.
  19. Kevin Appelt commented on patch set 5 02/25/22, 09:43

    UpgradeController.php:199 Reply

    The code is adjusted accordingly.

    UpgradeController.php:633 Reply

    The code is adjusted accordingly.
  20. Helmut Hummel commented on patch set 5 02/28/22, 22:01

    UpgradeController.php:199 Reply

    It is an excellent question. For now, I would leave it like that, especially because the root package is also recognized as package which requires some extra thoughts. In the long run, though, anything that can extend TYPO3 API should be considered being an extension.
  21. Helmut Hummel commented on patch set 5 V +1 02/28/22, 22:12

    Very nice cleanup! Thanks a lot!

    UpgradeController.php:639

    Does this actually do anything useful?
  22. Simon Gilli commented on patch set 5 V +1 CR +1 02/28/22, 22:13

    Thanks!
  23. Kevin Appelt commented on patch set 5 03/01/22, 06:05

    .

    UpgradeController.php:639 Reply

    The original code contained ->sortByName() and I wanted to make sure that also the packages from the Package Manager are sorted alphabetically in any case.
  24. Benni Mack commented on patch set 5 V +2 CR +2 03/01/22, 07:42

    UpgradeController.php:639 Reply

    Done
  25. Benni Mack merged patch set 6 03/01/22, 07:42