Review main Merged

73683[FEATURE] Skip translation of overridden form finisher options

Elias Häußler CR +2 V +2 Normal +116 −1 updated 04/28/22, 10:47

Commit message

If form finisher options are overridden via FlexForm, they must not
be translated by the TranslationService. Otherwise, they would probably
be overridden again by a localization from a translation file.

A new translation option "propertiesExcludedFromTranslation" has been
introduced to achieve this, skipping all those finisher options whose
option value has been changed by a FlexForm. The translation option is
only respected in `TranslationService::translateFinisherOption()`.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5