Review main Merged

73692[TASK] Validate regex validator pattern in form editor

Elias Häußler CR +2 V +2 Normal +77 −14 updated 04/27/22, 13:21

Commit message

In the form editor, backend users can currently insert any non-empty
strings for patterns of regular expression validators. This can lead to
situations where invalid pattern are inserted without getting immediate
feedback. Rather, this generates an error to the user when rendering the
form in the frontend.

To avoid those situations, backend users will now get an immediate
visual feedback if the inserted regex pattern is not valid. The
underlying check is rather basic and does not support all features of
PHP PCRE regular expressions. Since the RegularExpressionValidator
will be removed from the UI in v13, the improvement is suitable in
respect of the removal (see #97016). However, this is still a small
progress in this area.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 34

Show 14 more files