73695[TASK] Further improvements of the form editor/ inspector
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Björn Jacob +1
- Andreas Steiger +1
- Elias Häußler +1
-
Verified V +2 Done
- waldhacker +2
- Björn Jacob +1
- Andreas Steiger +1
- Elias Häußler +1
- core-ci +1 CI
Issues 1
Files 17
- Build/Sources/Sass/form.scss+68 −21
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/CheckboxEditor.html4+8 −4
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/FinishersEditor.html2+7 −3
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/FormElementHeaderEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/GridColumnViewPortConfigurationEditor.html+14 −6
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/MaximumFileSizeEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/MultiSelectEditor.html+10 −4
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/PropertyGridEditor.html+43 −41
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/RequiredValidatorEditor.html+12 −6
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/SingleSelectEditor.html+10 −4
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/TextareaEditor.html+5 −3
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/TextEditor.html+16 −14
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/Typo3WinBrowserEditor.html+12 −10
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/ValidationErrorMessageEditor.html2+6 −4
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/ValidatorsEditor.html+7 −3
- typo3/sysext/form/Resources/Public/Css/form.css+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/inspector-component.js+1 −1
Review log 2230
Show 35 earlier messages
-
Tobias Siegler uploaded patch set 1 02/24/22, 12:40
-
core-ci voted on patch set 1 V +1 02/24/22, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24192
-
Tobias Siegler rebased onto patch set 2 02/25/22, 14:47
-
core-ci voted on patch set 2 V +1 02/25/22, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24283
-
Tobias Siegler uploaded patch set 3 02/25/22, 15:02
-
core-ci voted on patch set 3 V +1 02/25/22, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24285
-
waldhacker marked it work in progress 02/26/22, 15:18
-
Tobias Siegler uploaded patch set 4 04/27/22, 10:33
-
core-ci voted on patch set 4 V +1 04/27/22, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26498
-
Tobias Siegler uploaded patch set 5 04/27/22, 15:33
-
core-ci voted on patch set 5 V +1 04/27/22, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26522
-
Björn Jacob updated the commit message in patch set 6 04/28/22, 08:29
-
Tobias Siegler marked it ready for review 04/28/22, 08:31
-
Andreas Steiger voted on patch set 6 V +1 CR +1 04/28/22, 08:40
-
core-ci voted on patch set 6 V -1 04/28/22, 08:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26561
-
Elias Häußler commented on patch set 6 04/28/22, 08:54
ValidationErrorMessageEditor.html:8Is the nested `t3-form-controls` class intended? -
Björn Jacob commented on patch set 6 CR -1 04/28/22, 08:55
Can you please provide two or three sentences what the patch does? Please add it to the commit message. -
Elias Häußler commented on patch set 6 04/28/22, 09:03
CheckboxEditor.html:10This <div> should be removed (probably using JS) if no explanationText is defined. Otherwise, this generates too much space between elements in the inspector. -
Elias Häußler commented on patch set 6 04/28/22, 09:11
CheckboxEditor.html:13In FormEngine, descriptions are placed between label and checkbox. Maybe we should streamline this with the form editor as well. -
Elias Häußler voted on patch set 6 CR -1 04/28/22, 09:11
-
Tobias Siegler uploaded patch set 7 04/28/22, 11:23
-
Tobias Siegler commented on patch set 6 04/28/22, 11:25
CheckboxEditor.html:10ReplyBy moving the description between label and checkbox (your other comment), this problem has become obsolete.CheckboxEditor.html:13ReplyDoneFinishersEditor.html:3ReplyDoneValidationErrorMessageEditor.html:8ReplyIt's not needed, was my mistake. -
core-ci voted on patch set 7 V +1 04/28/22, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26579
-
Tobias Siegler updated the commit message in patch set 8 04/28/22, 11:39
-
core-ci voted on patch set 8 V +1 04/28/22, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26582
-
Elias Häußler voted on patch set 8 V +1 CR +1 04/28/22, 13:30
-
Andreas Steiger voted on patch set 8 V +1 CR +1 04/28/22, 13:32
-
Björn Jacob voted on patch set 8 V +1 CR +1 04/28/22, 13:42
-
waldhacker voted on patch set 8 V +2 CR +2 04/28/22, 13:59
-
waldhacker merged patch set 9 04/28/22, 14:00
FinishersEditor.html:3