Review main Abandoned

73705[TASK] TSFE must not unset BE_USER without backup

Christian Kuhn CR 0 V 0 Easy +16 −9 updated 02/24/22, 21:56

Commit message

TSFE unsets $GLOBALS['BE_USER'] to determine the FE
page id in case user has no access to it. It does
that without resetting global state. This leads
to issues whith sub requests since single requests
may unset this global. EXT:solr seems to be a
victim here.

The patch changes TSFE to back up globals BE_USER
for determineId() fetch_the_id() calculation and
resets it afterwards to not kill further processing.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 02/24/22, 18:44

  2. core-ci voted on patch set 1 V +1 02/24/22, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24222

  3. Christian Kuhn commented on patch set 1 02/24/22, 21:56

    i'll abandon this approach: this is more a state-issue of ext:solr. and yes, core shouldn't simply unset globals, but this change can have various unknown side-effects that may be hard to track. we *may* come up with something for main-branch again, but v11 is far too risky (security-wise, unsure). we'll reject the issue and may come up with a new approach.
  4. Christian Kuhn abandoned the change 02/24/22, 21:56