Review main Merged

73720[TASK] Streamline checkboxes of form editor

Andreas Steiger CR +2 V +2 Easy +28 −18 updated 04/29/22, 07:24

Commit message

Change browser default checkboxes to TYPO3
toggle buttons or TYPO3 checkboxes in the form editor.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1927

Show 12 earlier messages
  1. Andreas Steiger uploaded patch set 1 02/25/22, 16:38

  2. core-ci voted on patch set 1 V +1 02/25/22, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24295

  1. Tobias Jungmann voted on patch set 1 CR +1 04/27/22, 08:34

  2. Andreas Steiger rebased onto patch set 2 04/27/22, 08:44

  3. Tobias Jungmann voted on patch set 2 CR +1 04/27/22, 08:49

  4. core-ci voted on patch set 2 V +1 04/27/22, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26496

  5. Tobias Jungmann voted on patch set 2 V +1 04/27/22, 09:01

  6. Andreas Steiger uploaded patch set 3 04/28/22, 08:18

  7. Andreas Steiger updated the commit message in patch set 4 04/28/22, 08:22

  8. core-ci voted on patch set 3 V +1 04/28/22, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26556

  9. core-ci voted on patch set 4 V +1 04/28/22, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26558

  10. Elias Häußler voted on patch set 4 V +1 04/28/22, 09:39

  11. Andreas Steiger uploaded patch set 5 04/28/22, 14:16

  12. Andreas Steiger uploaded patch set 6 04/28/22, 14:25

  13. core-ci voted on patch set 5 V -1 04/28/22, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26603

  14. core-ci voted on patch set 6 V +1 04/28/22, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26604

  15. waldhacker voted on patch set 6 V +1 CR +1 04/28/22, 14:55

  16. Elias Häußler commented on patch set 6 04/28/22, 15:17

    The spacing between a checkbox and the following property / element is lower than between other properties / elements. This can especially be seen in the email finisher options.

    PropertyGridEditor.html:25

    While we're at it, can't we use the default FormEngine checkbox here?
  17. waldhacker commented on patch set 6 V 0 CR 0 04/28/22, 15:23

    Reply

    Hm right, I did not notice that earlier while testing.
  18. Tobias Siegler uploaded patch set 7 04/28/22, 15:46

  19. core-ci voted on patch set 7 V +1 04/28/22, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26612

  20. Tobias Siegler uploaded patch set 8 04/29/22, 06:05

  21. core-ci voted on patch set 8 V +1 04/29/22, 06:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26634

  22. Björn Jacob commented on patch set 8 V +1 CR +1 04/29/22, 07:12

    Reply

    Done

    PropertyGridEditor.html:25 Reply

    This has been discussed. We agree on using the current style.
  23. Björn Jacob commented on patch set 8 04/29/22, 07:13

    PropertyGridEditor.html:25 Reply

    Done
  24. waldhacker voted on patch set 8 V +2 CR +2 04/29/22, 07:22

  25. waldhacker merged patch set 9 04/29/22, 07:24