73720[TASK] Streamline checkboxes of form editor
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Björn Jacob +1
-
Verified V +2 Done
- waldhacker +2
- Björn Jacob +1
- core-ci +1 CI
Issues 1
Files 6
- Build/Sources/Sass/form.scss+9 −0
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/CheckboxEditor.html+6 −8
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/PropertyGridEditor.html3+5 −1
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/RequiredValidatorEditor.html+6 −7
- typo3/sysext/form/Resources/Private/Language/Database.xlf+1 −1
- typo3/sysext/form/Resources/Public/Css/form.css+1 −1
Review log 1927
Show 12 earlier messages
-
Andreas Steiger uploaded patch set 1 02/25/22, 16:38
-
core-ci voted on patch set 1 V +1 02/25/22, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24295
-
Tobias Jungmann voted on patch set 1 CR +1 04/27/22, 08:34
-
Andreas Steiger rebased onto patch set 2 04/27/22, 08:44
-
Tobias Jungmann voted on patch set 2 CR +1 04/27/22, 08:49
-
core-ci voted on patch set 2 V +1 04/27/22, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26496
-
Tobias Jungmann voted on patch set 2 V +1 04/27/22, 09:01
-
Andreas Steiger uploaded patch set 3 04/28/22, 08:18
-
Andreas Steiger updated the commit message in patch set 4 04/28/22, 08:22
-
core-ci voted on patch set 3 V +1 04/28/22, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26556
-
core-ci voted on patch set 4 V +1 04/28/22, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26558
-
Elias Häußler voted on patch set 4 V +1 04/28/22, 09:39
-
Andreas Steiger uploaded patch set 5 04/28/22, 14:16
-
Andreas Steiger uploaded patch set 6 04/28/22, 14:25
-
core-ci voted on patch set 5 V -1 04/28/22, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26603
-
core-ci voted on patch set 6 V +1 04/28/22, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26604
-
waldhacker voted on patch set 6 V +1 CR +1 04/28/22, 14:55
-
Elias Häußler commented on patch set 6 04/28/22, 15:17
The spacing between a checkbox and the following property / element is lower than between other properties / elements. This can especially be seen in the email finisher options.PropertyGridEditor.html:25While we're at it, can't we use the default FormEngine checkbox here? -
waldhacker commented on patch set 6 V 0 CR 0 04/28/22, 15:23
Reply
Hm right, I did not notice that earlier while testing. -
Tobias Siegler uploaded patch set 7 04/28/22, 15:46
-
core-ci voted on patch set 7 V +1 04/28/22, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26612
-
Tobias Siegler uploaded patch set 8 04/29/22, 06:05
-
core-ci voted on patch set 8 V +1 04/29/22, 06:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26634
-
Björn Jacob commented on patch set 8 V +1 CR +1 04/29/22, 07:12
Reply
DonePropertyGridEditor.html:25ReplyThis has been discussed. We agree on using the current style. -
Björn Jacob commented on patch set 8 04/29/22, 07:13
PropertyGridEditor.html:25ReplyDone -
waldhacker voted on patch set 8 V +2 CR +2 04/29/22, 07:22
-
waldhacker merged patch set 9 04/29/22, 07:24