Review main Merged

73721[FEATURE] Add fragment option to Redirect Finisher

Gabe Troyan CR +2 V +2 Normal +179 −2 updated 04/29/22, 09:50

Commit message

This patch adds a new field called "fragment" to the EXT:form Redirect
finisher. It will be appended to the redirect URL (e.g. #c127). The
fragment can be either a content element identifier or a custom fragment
such as `foo`.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • Mathias Brodala +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2837

Show 812 earlier messages
  1. Gabe Troyan uploaded patch set 1 02/25/22, 16:47

  2. Mathias Brodala commented on patch set 1 02/25/22, 16:53

    RedirectFinisher.php:69

    If you do not any processing here ...

    RedirectFinisher.php:95

    ... then you can do the ltrim() dance here instead and avoid the condition.
  3. Mathias Brodala commented on patch set 1 02/25/22, 16:55

  4. core-ci voted on patch set 1 V -1 02/25/22, 16:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24297

  5. Gabe Troyan uploaded patch set 2 02/25/22, 17:25

  6. core-ci voted on patch set 2 V -1 02/25/22, 17:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24301

  7. Gabe Troyan uploaded patch set 3 02/25/22, 17:36

  8. core-ci voted on patch set 3 V +1 02/25/22, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24303

  9. Björn Jacob commented on patch set 3 CR -1 02/25/22, 19:47

    Can you please provide a feature documentation (changelog) for this patch?
  10. Gabe Troyan uploaded patch set 4 02/25/22, 22:28

  11. core-ci voted on patch set 4 V +1 02/25/22, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24308

  12. waldhacker uploaded patch set 5 02/26/22, 15:09

  1. core-ci voted on patch set 5 V +1 02/26/22, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24332

  2. waldhacker commented on patch set 5 02/26/22, 15:23

    RedirectFinisher.php:69 Reply

    Done

    RedirectFinisher.php:90 Reply

    Done

    RedirectFinisher.php:95 Reply

    Done
  3. waldhacker voted on patch set 5 V +1 CR +1 02/26/22, 15:23

  4. Mathias Brodala commented on patch set 5 02/28/22, 08:00

    Feature-83912-SpecifySectionRedirectFinisher.rst:28

    We should link to or mention that this is used to fill the typoLink "section" option which would mean that e.g. "#c9" could be written as "9" too. Also not sure if "#" can be skipped.
  5. Björn Jacob uploaded patch set 6 03/04/22, 15:20

  6. Björn Jacob commented on patch set 6 V +1 CR +1 03/04/22, 15:21

    Feature-83912-SpecifySectionRedirectFinisher.rst:28 Reply

    Done
  7. Mathias Brodala commented on patch set 6 CR -1 03/04/22, 15:23

    Redirect.rst:129

    #c9
  8. core-ci voted on patch set 6 V +1 03/04/22, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24563

  9. Björn Jacob uploaded patch set 7 03/04/22, 15:45

  10. Björn Jacob commented on patch set 7 V +1 CR +1 03/04/22, 15:45

    Redirect.rst:129 Reply

    Done
  11. Mathias Brodala voted on patch set 7 CR +1 03/04/22, 16:06

  12. Oli Bartsch commented on patch set 7 03/04/22, 19:19

    Feature-83912-SpecifySectionRedirectFinisher.rst:30

    As most installations use fluid_styled_content, the example should properly be `c9`, see https://github.com/TYPO3/typo3/blob/main/typo3/sysext/fluid_styled_content/Resources/Private/Layouts/Default.html#L5
  13. Björn Jacob commented on patch set 7 V -1 CR 0 04/27/22, 08:24

    I am having a question: would it be possible to have a page selector instead of entering the section uid? UX-wise it would be way better.
  14. Elias Häußler uploaded patch set 8 04/27/22, 12:33

  15. core-ci voted on patch set 8 V -1 04/27/22, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26505

  16. Elias Häußler uploaded patch set 9 04/27/22, 12:44

  17. core-ci voted on patch set 9 V +1 04/27/22, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26507

  18. Björn Jacob commented on patch set 9 V -1 04/27/22, 14:08

    -1 since we are testing a new Typo3WinBrowser.
  19. Elias Häußler uploaded patch set 10 04/29/22, 09:10

  20. Elias Häußler commented on patch set 10 04/29/22, 09:17

    Feature-83912-SpecifySectionRedirectFinisher.rst:30 Reply

    I'd say the preferred way of defining a fragment is by using the element browser which generates UIDs (`9` instead of `c9`). Therefore, using `c9` as example probably does not define the "most common" use case. Since both variants lead to the same result, it's probably okay to use only `9`. What do you mean?
  21. core-ci voted on patch set 10 V +1 04/29/22, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26647

  22. Björn Jacob commented on patch set 10 V +1 CR +1 04/29/22, 09:31

    Feature-83912-SpecifySectionRedirectFinisher.rst:30 Reply

    I am for keeping the example as is.
  23. Mathias Brodala voted on patch set 10 V +1 CR +1 04/29/22, 09:43

  24. waldhacker commented on patch set 10 V +2 CR +2 04/29/22, 09:49

    Feature-83912-SpecifySectionRedirectFinisher.rst:30 Reply

    Done
  25. waldhacker merged patch set 11 04/29/22, 09:50