73721[FEATURE] Add fragment option to Redirect Finisher
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Björn Jacob +1
- Mathias Brodala +1
-
Verified V +2 Done
- waldhacker +2
- Björn Jacob +1
- Mathias Brodala +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-83912-SpecifySectionRedirectFinisher.rst6new+34 −0
- typo3/sysext/form/Classes/Domain/Finishers/RedirectFinisher.php6+5 −2
- typo3/sysext/form/Configuration/Yaml/Finishers/Redirect.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Form.yaml+9 −0
- typo3/sysext/form/Documentation/D/FinisherOptions/Index.rst+19 −0
- typo3/sysext/form/Documentation/I/Config/proto/finishersDefinition/finishers/Redirect.rst2+36 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/30/editors/400.rstnew+38 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/30.rst+9 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor.rst+9 −0
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form.rst+3 −0
- typo3/sysext/form/Resources/Private/Language/Database.xlf+12 −0
Review log 2837
Show 812 earlier messages
-
Gabe Troyan uploaded patch set 1 02/25/22, 16:47
-
Mathias Brodala commented on patch set 1 02/25/22, 16:53
RedirectFinisher.php:95... then you can do the ltrim() dance here instead and avoid the condition. -
Mathias Brodala commented on patch set 1 02/25/22, 16:55
RedirectFinisher.php:90You can also use "section" here: https://docs.typo3.org/m/typo3/reference-typoscript/11.5/en-us/Functions/Typolink.html#section -
core-ci voted on patch set 1 V -1 02/25/22, 16:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24297
-
Gabe Troyan uploaded patch set 2 02/25/22, 17:25
-
core-ci voted on patch set 2 V -1 02/25/22, 17:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24301
-
Gabe Troyan uploaded patch set 3 02/25/22, 17:36
-
core-ci voted on patch set 3 V +1 02/25/22, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24303
-
Björn Jacob commented on patch set 3 CR -1 02/25/22, 19:47
Can you please provide a feature documentation (changelog) for this patch? -
Gabe Troyan uploaded patch set 4 02/25/22, 22:28
-
core-ci voted on patch set 4 V +1 02/25/22, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24308
-
waldhacker uploaded patch set 5 02/26/22, 15:09
-
core-ci voted on patch set 5 V +1 02/26/22, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24332
-
waldhacker commented on patch set 5 02/26/22, 15:23
RedirectFinisher.php:69ReplyDoneRedirectFinisher.php:90ReplyDoneRedirectFinisher.php:95ReplyDone -
waldhacker voted on patch set 5 V +1 CR +1 02/26/22, 15:23
-
Mathias Brodala commented on patch set 5 02/28/22, 08:00
Feature-83912-SpecifySectionRedirectFinisher.rst:28We should link to or mention that this is used to fill the typoLink "section" option which would mean that e.g. "#c9" could be written as "9" too. Also not sure if "#" can be skipped. -
Björn Jacob uploaded patch set 6 03/04/22, 15:20
-
Björn Jacob commented on patch set 6 V +1 CR +1 03/04/22, 15:21
Feature-83912-SpecifySectionRedirectFinisher.rst:28ReplyDone -
Mathias Brodala commented on patch set 6 CR -1 03/04/22, 15:23
Redirect.rst:129#c9 -
core-ci voted on patch set 6 V +1 03/04/22, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24563
-
Björn Jacob uploaded patch set 7 03/04/22, 15:45
-
Björn Jacob commented on patch set 7 V +1 CR +1 03/04/22, 15:45
Redirect.rst:129ReplyDone -
Mathias Brodala voted on patch set 7 CR +1 03/04/22, 16:06
-
Oli Bartsch commented on patch set 7 03/04/22, 19:19
Feature-83912-SpecifySectionRedirectFinisher.rst:30As most installations use fluid_styled_content, the example should properly be `c9`, see https://github.com/TYPO3/typo3/blob/main/typo3/sysext/fluid_styled_content/Resources/Private/Layouts/Default.html#L5 -
Björn Jacob commented on patch set 7 V -1 CR 0 04/27/22, 08:24
I am having a question: would it be possible to have a page selector instead of entering the section uid? UX-wise it would be way better. -
Elias Häußler uploaded patch set 8 04/27/22, 12:33
-
core-ci voted on patch set 8 V -1 04/27/22, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26505
-
Elias Häußler uploaded patch set 9 04/27/22, 12:44
-
core-ci voted on patch set 9 V +1 04/27/22, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26507
-
Björn Jacob commented on patch set 9 V -1 04/27/22, 14:08
-1 since we are testing a new Typo3WinBrowser. -
Elias Häußler uploaded patch set 10 04/29/22, 09:10
-
Elias Häußler commented on patch set 10 04/29/22, 09:17
Feature-83912-SpecifySectionRedirectFinisher.rst:30ReplyI'd say the preferred way of defining a fragment is by using the element browser which generates UIDs (`9` instead of `c9`). Therefore, using `c9` as example probably does not define the "most common" use case. Since both variants lead to the same result, it's probably okay to use only `9`. What do you mean? -
core-ci voted on patch set 10 V +1 04/29/22, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26647
-
Björn Jacob commented on patch set 10 V +1 CR +1 04/29/22, 09:31
Feature-83912-SpecifySectionRedirectFinisher.rst:30ReplyI am for keeping the example as is. -
Mathias Brodala voted on patch set 10 V +1 CR +1 04/29/22, 09:43
-
waldhacker commented on patch set 10 V +2 CR +2 04/29/22, 09:49
Feature-83912-SpecifySectionRedirectFinisher.rst:30ReplyDone -
waldhacker merged patch set 11 04/29/22, 09:50
RedirectFinisher.php:69