73731[BUGFIX] Avoid variable leaks in TCA/TCA Overrides
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php7+15 −2
- typo3/sysext/core/Tests/Functional/Utility/ExtensionManagementUtility/Fixtures/Extensions/test_tcaoverride_a/Configuration/TCA/Overrides/test_tcaoverride_a.phpnew+16 −0
- typo3/sysext/core/Tests/Functional/Utility/ExtensionManagementUtility/Fixtures/Extensions/test_tcaoverride_a/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Utility/ExtensionManagementUtility/Fixtures/Extensions/test_tcaoverride_b/Configuration/TCA/Overrides/test_tcaoverride_b.phpnew+16 −0
- typo3/sysext/core/Tests/Functional/Utility/ExtensionManagementUtility/Fixtures/Extensions/test_tcaoverride_b/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Utility/ExtensionManagementUtility/Fixtures/Extensions/test_tca_a/Configuration/TCA/test_tca_a.phpnew+17 −0
- typo3/sysext/core/Tests/Functional/Utility/ExtensionManagementUtility/Fixtures/Extensions/test_tca_a/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Utility/ExtensionManagementUtility/Fixtures/Extensions/test_tca_b/Configuration/TCA/test_tca_b.phpnew+17 −0
- typo3/sysext/core/Tests/Functional/Utility/ExtensionManagementUtility/Fixtures/Extensions/test_tca_b/Configuration/TCA/text_tca_b_noreturn.phpnew+3 −0
- typo3/sysext/core/Tests/Functional/Utility/ExtensionManagementUtility/Fixtures/Extensions/test_tca_b/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Utility/ExtensionManagementUtility/ExtensionManagementUtilityTcaOverrideRequireTest.php2new+24 −0
- typo3/sysext/core/Tests/Functional/Utility/ExtensionManagementUtility/ExtensionManagementUtilityTcaRequireTest.php2new+39 −0
Review log 2433
Show 48 earlier messages
-
Stefan Bürk uploaded patch set 1 02/26/22, 22:50
-
Stefan Bürk updated the commit message in patch set 2 02/26/22, 22:53
-
core-ci voted on patch set 1 V -1 02/26/22, 23:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24345
-
core-ci voted on patch set 2 V -1 02/26/22, 23:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24346
-
Stefan Bürk uploaded patch set 3 02/26/22, 23:06
-
Stefan Bürk uploaded patch set 4 02/26/22, 23:11
-
core-ci voted on patch set 3 V +1 02/26/22, 23:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24347
-
core-ci voted on patch set 4 V +1 02/26/22, 23:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24348
-
Stefan Bürk uploaded patch set 5 02/26/22, 23:34
-
core-ci voted on patch set 5 V +1 02/26/22, 23:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24349
-
Christian Kuhn commented on patch set 5 02/27/22, 14:57
Looks good to me, but I'm unsure if we should merge this in v11: People do weird stuff, maybe we'd want to do it v12 only to not introduce something in v11? -
Stefan Bürk commented on patch set 5 02/27/22, 15:07
Reply
Ack. Let's play on safe ground. -
Stefan Bürk updated the commit message in patch set 6 02/27/22, 15:07
-
core-ci voted on patch set 6 V +1 02/27/22, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24378
-
Mathias Brodala commented on patch set 6 02/28/22, 07:48
ExtensionManagementUtility.php:1484This would lead to a hard type error if no array is returned. Which would be a breaking change since ...ExtensionManagementUtility.php:1497... we silently skipped such a broken file as of now. -
Stefan Bürk commented on patch set 6 02/28/22, 08:23
ExtensionManagementUtility.php:1484ReplyAck. Can look into it later on. Will test what's ok for here (to be non breaking). -
Stefan Bürk voted on patch set 6 CR -1 02/28/22, 08:23
-
Stefan Bürk uploaded patch set 7 02/28/22, 20:20
-
Stefan Bürk commented on patch set 7 02/28/22, 20:21
ExtensionManagementUtility.php:1484ReplyDone. Added test for it to and added corresponding note.ExtensionManagementUtility.php:1497ReplyDone -
core-ci voted on patch set 7 V +1 02/28/22, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24390
-
Stefan Bürk rebased onto patch set 8 03/01/22, 19:28
-
core-ci voted on patch set 8 V +1 03/01/22, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24416
-
Mathias Brodala voted on patch set 8 CR +1 03/02/22, 07:47
-
Nikita Hovratov commented on patch set 8 V +1 03/05/22, 00:49
ExtensionManagementUtility.php:1486mitigated by an arrayExtensionManagementUtilityTcaOverrideRequireTest.php:20failsExtensionManagementUtilityTcaRequireTest.php:35fails -
Nikita Hovratov commented on patch set 8 03/05/22, 00:52
The first part of this sentence reads icky. -
Stefan Bürk uploaded patch set 9 03/05/22, 11:47
-
Stefan Bürk updated the commit message in patch set 10 03/05/22, 12:03
-
Stefan Bürk commented on patch set 10 03/05/22, 12:05
Reply
DoneExtensionManagementUtility.php:1486ReplyDoneExtensionManagementUtilityTcaOverrideRequireTest.php:20ReplyDoneExtensionManagementUtilityTcaRequireTest.php:35ReplyDone -
core-ci voted on patch set 10 V +1 03/05/22, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24607
-
Stefan Bürk commented on patch set 10 03/05/22, 12:35
patchset 9 did not triggerd a pipeline run - thus no vote. -
Nikita Hovratov voted on patch set 10 V +1 CR +1 03/05/22, 21:03
-
Christian Kuhn voted on patch set 10 V +2 CR +2 03/05/22, 23:11
-
Christian Kuhn merged patch set 11 03/05/22, 23:11