Review 11.5 Merged

73734[TASK] Fix the return type annotation of getIndpEnv

Christian Kuhn CR +2 V +2 Easy +2 −12 updated 02/27/22, 14:59

Commit message

GeneralUtility::getIndpEnv can also return values other than string,
e.g., PATH_INFO might return null, and TYPO3_SSL will return a
bool. Also, _ARRAY will return an array of all possible scalar
values.

The return type annotation needs to correctly reflect that in order
for static type analysis to be able to work correctly when this
function is called.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2

Issues 1

Files 2

Review log 3

  1. Christian Kuhn uploaded patch set 1 02/27/22, 14:33

  2. Christian Kuhn commented on patch set 1 V +2 CR +2 02/27/22, 14:59

    green in CI, somehow vote got lost.
  3. Christian Kuhn merged patch set 2 02/27/22, 14:59