Review main Merged

73741[TASK] Resolve contentFromPid at an earlier stage

Benni Mack CR +2 V +2 Easy +2 −3 updated 03/01/22, 08:04

Commit message

Instead of resolving the value $TSFE->contentPid
at a point when the page generation happens,
this is now done within "determineId", which allows
to use this value in custom middlewares.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack uploaded patch set 1 02/28/22, 22:03

  2. Benni Mack updated the commit message in patch set 2 02/28/22, 22:05

  3. core-ci voted on patch set 1 V +1 02/28/22, 22:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24394

  4. core-ci voted on patch set 2 V +1 02/28/22, 22:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24395

  5. Georg Ringer voted on patch set 2 V +1 CR +1 03/01/22, 06:36

  6. Oli Bartsch voted on patch set 2 V +2 CR +2 03/01/22, 08:04

  7. Oli Bartsch merged patch set 3 03/01/22, 08:04