73764[BUGFIX] Pass current rendarable context to condition evaluation
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Andreas Kienast +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2635
Show 610 earlier messages
-
Helmut Hummel uploaded patch set 1 03/02/22, 10:14
-
core-ci voted on patch set 1 V -1 03/02/22, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24444
-
Helmut Hummel rebased onto patch set 2 03/02/22, 11:09
-
Helmut Hummel rebased onto patch set 3 03/02/22, 11:09
-
core-ci voted on patch set 2 V -1 03/02/22, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24446
-
core-ci voted on patch set 2 V +1 03/02/22, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24446
-
Helmut Hummel rebased onto patch set 4 03/07/22, 15:35
-
core-ci voted on patch set 4 V +1 03/07/22, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24667
-
Benni Mack voted on patch set 4 CR +1 03/14/22, 17:18
-
Markus Volkmer voted on patch set 4 CR +1 03/18/22, 19:18
-
Nikita Hovratov voted on patch set 4 CR +1 03/18/22, 19:45
-
Simon Schaufelberger uploaded patch set 5 06/10/22, 11:27
-
core-ci voted on patch set 5 V +1 06/10/22, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27914
-
Jörg Bösche voted on patch set 5 CR +1 06/24/22, 19:32
-
Oliver Hader commented on patch set 5 06/28/22, 09:19
Having a short example would be great, probably extending the existing docs at https://docs.typo3.org/c/typo3/cms-form/main/en-us/I/Concepts/Variants/Index.html -
Oliver Hader voted on patch set 5 CR +1 06/28/22, 09:19
-
Moritz Ngo voted on patch set 5 CR +1 08/05/22, 21:27
-
Moritz Ngo voted on patch set 5 V +1 08/05/22, 21:33
-
Benni Mack updated the commit message in patch set 6
CR +1V +105/03/23, 09:20 -
core-ci voted on patch set 6 V -1 05/03/23, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41397
-
Helmut Hummel uploaded patch set 7
V -107/17/23, 09:06 -
core-ci voted on patch set 7 V +1 07/17/23, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44203
-
Helmut Hummel uploaded patch set 8
V +107/17/23, 09:24 -
Helmut Hummel commented on patch set 7 07/17/23, 09:24
Reply
done -
core-ci voted on patch set 8 V +1 07/17/23, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44205
-
Mathias Brodala commented on patch set 8 07/17/23, 09:56
RenderableVariant.php:94Tiny nitpick: this should be "renderable" to make it clear that this could be any kind of renderable, not necessarily an element, e.g. the FormDefinition, a Page or a Section. -
Oliver Klee commented on patch set 8 07/17/23, 09:58
Index.rst:159AFAIK, in ReST, the underlining of a heading should have the same length as the heading. -
Helmut Hummel uploaded patch set 9
V +107/17/23, 22:17 -
Helmut Hummel commented on patch set 9 07/17/23, 22:18
RenderableVariant.php:94Replydone. good catch. called it "renderable" now, since the "current" appeared somewhat redundant as wellIndex.rst:159ReplyDone -
Helmut Hummel commented on patch set 9 07/17/23, 22:19
RenderableVariant.php:94Replydone -
core-ci voted on patch set 9 V +1 07/17/23, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44225
-
Christian Kuhn voted on patch set 9 V +1 CR +1 07/18/23, 08:05
-
Andreas Kienast voted on patch set 9 CR +1 07/18/23, 08:10
-
Stefan Bürk voted on patch set 9 V +2 CR +2 07/18/23, 08:29
-
Stefan Bürk merged patch set 10 07/18/23, 08:29