Review main Merged

73764[BUGFIX] Pass current rendarable context to condition evaluation

Helmut Hummel CR +2 V +2 Easy +37 −2 updated 07/18/23, 08:29

Commit message

Form elements are represented by PHP objects,
which hold some state, which can be modified during form runtime.

However it is impossible to access this state in a variant condition,
because the instance of the current element is not passed
to the expression language evaluation.

The current renderable is now passed as additional
variable to the condition evaluation.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2635

Show 610 earlier messages
  1. Helmut Hummel uploaded patch set 1 03/02/22, 10:14

  2. core-ci voted on patch set 1 V -1 03/02/22, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24444

  3. Helmut Hummel rebased onto patch set 2 03/02/22, 11:09

  4. Helmut Hummel rebased onto patch set 3 03/02/22, 11:09

  5. core-ci voted on patch set 2 V -1 03/02/22, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24446

  6. core-ci voted on patch set 2 V +1 03/02/22, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24446

  7. Helmut Hummel rebased onto patch set 4 03/07/22, 15:35

  8. core-ci voted on patch set 4 V +1 03/07/22, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24667

  9. Benni Mack voted on patch set 4 CR +1 03/14/22, 17:18

  10. Markus Volkmer voted on patch set 4 CR +1 03/18/22, 19:18

  1. Nikita Hovratov voted on patch set 4 CR +1 03/18/22, 19:45

  2. Simon Schaufelberger uploaded patch set 5 06/10/22, 11:27

  3. core-ci voted on patch set 5 V +1 06/10/22, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27914

  4. Jörg Bösche voted on patch set 5 CR +1 06/24/22, 19:32

  5. Oliver Hader commented on patch set 5 06/28/22, 09:19

    Having a short example would be great, probably extending the existing docs at https://docs.typo3.org/c/typo3/cms-form/main/en-us/I/Concepts/Variants/Index.html
  6. Oliver Hader voted on patch set 5 CR +1 06/28/22, 09:19

  7. Moritz Ngo voted on patch set 5 CR +1 08/05/22, 21:27

  8. Moritz Ngo voted on patch set 5 V +1 08/05/22, 21:33

  9. Benni Mack updated the commit message in patch set 6 CR +1 V +1 05/03/23, 09:20

  10. core-ci voted on patch set 6 V -1 05/03/23, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41397

  11. Helmut Hummel uploaded patch set 7 V -1 07/17/23, 09:06

  12. core-ci voted on patch set 7 V +1 07/17/23, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44203

  13. Helmut Hummel uploaded patch set 8 V +1 07/17/23, 09:24

  14. Helmut Hummel commented on patch set 7 07/17/23, 09:24

    Reply

    done
  15. core-ci voted on patch set 8 V +1 07/17/23, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44205

  16. Mathias Brodala commented on patch set 8 07/17/23, 09:56

    RenderableVariant.php:94

    Tiny nitpick: this should be "renderable" to make it clear that this could be any kind of renderable, not necessarily an element, e.g. the FormDefinition, a Page or a Section.
  17. Oliver Klee commented on patch set 8 07/17/23, 09:58

    Index.rst:159

    AFAIK, in ReST, the underlining of a heading should have the same length as the heading.
  18. Helmut Hummel uploaded patch set 9 V +1 07/17/23, 22:17

  19. Helmut Hummel commented on patch set 9 07/17/23, 22:18

    RenderableVariant.php:94 Reply

    done. good catch. called it "renderable" now, since the "current" appeared somewhat redundant as well

    Index.rst:159 Reply

    Done
  20. Helmut Hummel commented on patch set 9 07/17/23, 22:19

    RenderableVariant.php:94 Reply

    done
  21. core-ci voted on patch set 9 V +1 07/17/23, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44225

  22. Christian Kuhn voted on patch set 9 V +1 CR +1 07/18/23, 08:05

  23. Andreas Kienast voted on patch set 9 CR +1 07/18/23, 08:10

  24. Stefan Bürk voted on patch set 9 V +2 CR +2 07/18/23, 08:29

  25. Stefan Bürk merged patch set 10 07/18/23, 08:29