Review main Merged

73769[TASK] Clean up BE_USER->checkWorkspace() method

Benni Mack CR +2 V +2 Normal +71 −91 updated 03/04/22, 07:26

Commit message

The method checkWorkspace() has been cleaned up
as much functionality has been removed in previous
versions.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 912

  1. Benni Mack uploaded patch set 1 03/03/22, 07:52

  2. core-ci voted on patch set 1 V -1 03/03/22, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24493

  3. Benni Mack uploaded patch set 2 03/03/22, 09:08

  4. core-ci voted on patch set 2 V +1 03/03/22, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24499

  5. Stefan Bürk commented on patch set 2 03/03/22, 09:33

    BackendUserAuthentication.php:1840

    Would anything speak agaist using return-type ': array|false' here ? At least it seams that return is only false or an array ...
  6. Benni Mack uploaded patch set 3 03/03/22, 09:43

  7. Benni Mack commented on patch set 3 03/03/22, 09:44

    BackendUserAuthentication.php:1840 Reply

    Done
  8. core-ci voted on patch set 3 V +1 03/03/22, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24500

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 03/03/22, 12:52

  10. Andreas Kienast voted on patch set 3 CR +1 03/03/22, 14:23

  11. Andreas Kienast voted on patch set 3 V +2 CR +2 03/04/22, 07:26

  12. Andreas Kienast merged patch set 4 03/04/22, 07:26