Review main Merged

73795[TASK] Move TSFE->getPageAndRootlineWithDomain into fetch_the_id()

Benni Mack CR +2 V +2 Normal +24 −32 updated 03/03/22, 13:18

Commit message

In order to continue with further refactorings,
the method "getPageAndRootlineWithDomain()" is
moved into fetch_the_id().

In addition, the call to initUserGroups()
can be simplified these days, which is done here
as well. The method can be deprecated separately
later-on.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 03/03/22, 12:15

  2. core-ci voted on patch set 1 V +1 03/03/22, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24505

  3. Benni Mack commented on patch set 2 03/03/22, 12:48

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 03/03/22, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24515

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 03/03/22, 13:00

  6. Susi Moog voted on patch set 2 V +1 CR +1 03/03/22, 13:18

  7. Benni Mack voted on patch set 2 V +2 CR +2 03/03/22, 13:18

  8. Benni Mack merged patch set 3 03/03/22, 13:18