73796[BUGFIX] Fix PHP 8.0 warning with inline sychronize
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlineContentElementLocalizeSynchronizeCest.phpnew+119 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlinePagesLocalizeResourceCest.phpnew+72 −0
Review log 1014
-
Christian Kuhn uploaded patch set 1 03/03/22, 12:21
-
Benni Mack commented on patch set 1 03/03/22, 12:25
"Fix PHP 8.0 warning..." -
core-ci voted on patch set 1 V -1 03/03/22, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24507
-
Christian Kuhn uploaded patch set 2 03/03/22, 12:33
-
Christian Kuhn updated the commit message in patch set 3 03/03/22, 12:34
-
Christian Kuhn commented on patch set 3 03/03/22, 12:34
Reply
Done -
Christian Kuhn uploaded patch set 4 03/03/22, 12:36
-
core-ci voted on patch set 4 V +1 03/03/22, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24513
-
core-ci voted on patch set 2 V +1 03/03/22, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24509
-
core-ci voted on patch set 3 V -1 03/03/22, 12:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24512
-
Stefan Bürk commented on patch set 4 V +1 CR +1 03/03/22, 13:14
patchset 3 had postgres / openssl issue. restarted it and pipeline green - ci revote lost in space .... -
Benni Mack voted on patch set 4 V +1 CR +1 03/03/22, 13:19
-
Christian Kuhn voted on patch set 4 V +2 CR +2 03/03/22, 22:14
-
Christian Kuhn merged patch set 5 03/03/22, 22:14