73797[TASK] Add types to internal properties of TSFE
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1720
-
Benni Mack uploaded patch set 1 03/03/22, 13:10
-
Oliver Klee commented on patch set 1 03/03/22, 14:09
TypoScriptFrontendController.php:253This line can be removed as well.TypoScriptFrontendController.php:334This line can be removed as well.TypoScriptFrontendController.php:339This line can be removed as well.TypoScriptFrontendController.php:346This line can be removed as well.TypoScriptFrontendController.php:353This line can be removed as well.TypoScriptFrontendController.php:362This line can be removed as well.TypoScriptFrontendController.php:376This line can be removed as well. -
Benni Mack commented on patch set 2 03/03/22, 14:25
Published edit on patch set 1. -
Benni Mack commented on patch set 2 03/03/22, 14:26
TypoScriptFrontendController.php:221ReplyDoneTypoScriptFrontendController.php:253ReplyDoneTypoScriptFrontendController.php:334ReplyDoneTypoScriptFrontendController.php:339ReplyDoneTypoScriptFrontendController.php:346ReplyDoneTypoScriptFrontendController.php:353ReplyDoneTypoScriptFrontendController.php:362ReplyDoneTypoScriptFrontendController.php:376ReplyDone -
core-ci voted on patch set 2 V -1 03/03/22, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24518
-
Benni Mack commented on patch set 3 03/03/22, 14:44
Published edit on patch set 2. -
Oliver Klee commented on patch set 3 03/03/22, 14:45
TypoScriptFrontendController.php:397This property needs to be nullable, it seems. (And the original PHPDoc type annotation was incorrect.) -
Oliver Klee commented on patch set 3 03/03/22, 14:46
TypoScriptFrontendController.php:397Reply(Marking as already done - your're really quick, Benni! :-) ) -
Oliver Klee voted on patch set 3 CR +1 03/03/22, 14:47
-
Christian Kuhn rebased onto patch set 4 03/04/22, 20:49
-
Oliver Klee voted on patch set 4 CR +1 03/04/22, 20:52
-
Stefan Bürk uploaded patch set 5 03/04/22, 20:53
-
Oliver Klee voted on patch set 5 CR +1 03/04/22, 21:30
-
core-ci voted on patch set 5 V -1 03/04/22, 21:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24592
-
Stefan Bürk uploaded patch set 6 03/04/22, 22:11
-
core-ci voted on patch set 6 V +1 03/04/22, 22:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24594
-
Stefan Bürk voted on patch set 6 V +1 CR +1 03/04/22, 22:21
-
Oliver Klee voted on patch set 6 CR +1 03/04/22, 23:11
-
Christian Kuhn voted on patch set 6 V +2 CR +2 03/05/22, 20:21
-
Christian Kuhn merged patch set 7 03/05/22, 20:21
TypoScriptFrontendController.php:221