Review main Merged

73797[TASK] Add types to internal properties of TSFE

Benni Mack CR +2 V +2 Normal +22 −56 updated 03/05/22, 20:21

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1720

  1. Benni Mack uploaded patch set 1 03/03/22, 13:10

  2. Oliver Klee commented on patch set 1 03/03/22, 14:09

    TypoScriptFrontendController.php:221

    This line can be removed as well.

    TypoScriptFrontendController.php:253

    This line can be removed as well.

    TypoScriptFrontendController.php:334

    This line can be removed as well.

    TypoScriptFrontendController.php:339

    This line can be removed as well.

    TypoScriptFrontendController.php:346

    This line can be removed as well.

    TypoScriptFrontendController.php:353

    This line can be removed as well.

    TypoScriptFrontendController.php:362

    This line can be removed as well.

    TypoScriptFrontendController.php:376

    This line can be removed as well.
  3. Benni Mack commented on patch set 2 03/03/22, 14:25

    Published edit on patch set 1.
  4. Benni Mack commented on patch set 2 03/03/22, 14:26

    TypoScriptFrontendController.php:221 Reply

    Done

    TypoScriptFrontendController.php:253 Reply

    Done

    TypoScriptFrontendController.php:334 Reply

    Done

    TypoScriptFrontendController.php:339 Reply

    Done

    TypoScriptFrontendController.php:346 Reply

    Done

    TypoScriptFrontendController.php:353 Reply

    Done

    TypoScriptFrontendController.php:362 Reply

    Done

    TypoScriptFrontendController.php:376 Reply

    Done
  5. core-ci voted on patch set 2 V -1 03/03/22, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24518

  6. Benni Mack commented on patch set 3 03/03/22, 14:44

    Published edit on patch set 2.
  7. Oliver Klee commented on patch set 3 03/03/22, 14:45

    TypoScriptFrontendController.php:397

    This property needs to be nullable, it seems. (And the original PHPDoc type annotation was incorrect.)
  8. Oliver Klee commented on patch set 3 03/03/22, 14:46

    TypoScriptFrontendController.php:397 Reply

    (Marking as already done - your're really quick, Benni! :-) )
  9. Oliver Klee voted on patch set 3 CR +1 03/03/22, 14:47

  10. Christian Kuhn rebased onto patch set 4 03/04/22, 20:49

  11. Oliver Klee voted on patch set 4 CR +1 03/04/22, 20:52

  12. Stefan Bürk uploaded patch set 5 03/04/22, 20:53

  13. Oliver Klee voted on patch set 5 CR +1 03/04/22, 21:30

  14. core-ci voted on patch set 5 V -1 03/04/22, 21:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24592

  15. Stefan Bürk uploaded patch set 6 03/04/22, 22:11

  16. core-ci voted on patch set 6 V +1 03/04/22, 22:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24594

  17. Stefan Bürk voted on patch set 6 V +1 CR +1 03/04/22, 22:21

  18. Oliver Klee voted on patch set 6 CR +1 03/04/22, 23:11

  19. Christian Kuhn voted on patch set 6 V +2 CR +2 03/05/22, 20:21

  20. Christian Kuhn merged patch set 7 03/05/22, 20:21