Review main Abandoned Breaking

73818[POC][!!!][TASK] Strict core caches

Christian Kuhn CR 0 V 0 Expert +494 −1130 updated 07/30/22, 07:52

Commit message

This looks at the current cache implementation to see
what needs to be done to harden it.

This is breaking due to interface changes, but can be
kept b/w compatible for 3rd party that want to support
both v11 and v12 quite easily.

Additionally, it would be possible to implement both
psr-6 and psr-16, only set() of psr-16 gives headaches
due to the colliding signature with our set(). But
we could still work around that.

However, when looking at all this, and considering
the fact that this patch would be breaking, we may
be better off switching to symfony cache component
entirely, and keeping just a deprecated facade for
current usages. This would have various advantages:
The symfony cache is tag-aware and gives some further
features like stambede protection which we could
potentially use at some point. We probably could
adapt our rather well optimized tag-aware
Typo3DatabaseBackend too, since the pdo backend of
symfony is not tag-aware, but we most likely want
to keep a tag-aware db based cache implementation.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Files 78

Show 58 more files