Review main Merged

73823[TASK] Avoid unreachable return in BackendUtility

Christian Kuhn CR +2 V +2 Normal +29 −46 updated 03/05/22, 21:15

Commit message

The methods check for empty options early,
return empty string at the end can't be reached.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Christian Kuhn uploaded patch set 1 03/05/22, 19:11

  2. core-ci voted on patch set 1 V +1 03/05/22, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24616

  3. Stefan Bürk commented on patch set 1 03/05/22, 20:41

    BackendUtility.php:2220

    I wonder - if this return statemant was unreachable ... then the if() starting in 2204 should be superflous too - or do i miss something ? early return if no menuItems. For each menu item is a option created. so the if not empty check and nested block is superflous too - mind to remove that too ?

    BackendUtility.php:2276

    same here ... the if condition is superflous. See comment above.
  4. Christian Kuhn uploaded patch set 2 03/05/22, 20:52

  5. Christian Kuhn commented on patch set 2 03/05/22, 20:52

    BackendUtility.php:2220 Reply

    Done

    BackendUtility.php:2276 Reply

    Done
  6. Stefan Bürk voted on patch set 2 V +1 CR +1 03/05/22, 21:01

  7. core-ci voted on patch set 2 V +1 03/05/22, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24630

  8. Oliver Klee voted on patch set 2 CR +1 03/05/22, 21:02

  9. Nikita Hovratov voted on patch set 2 V +1 CR +1 03/05/22, 21:14

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 03/05/22, 21:15

  11. Christian Kuhn merged patch set 3 03/05/22, 21:15