Review main Merged

73824[TASK] Harden core ConfigurationManager

Christian Kuhn CR +2 V +2 Easy +6 −16 updated 03/05/22, 21:02

Commit message

Add a couple of return type hints and avoid an
unreachable else in this @internal class.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Christian Kuhn uploaded patch set 1 03/05/22, 19:17

  2. Christian Kuhn rebased onto patch set 2 03/05/22, 19:52

  3. core-ci voted on patch set 2 V +1 03/05/22, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24622

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 03/05/22, 20:28

  5. Nikita Hovratov voted on patch set 2 V +1 CR +1 03/05/22, 20:31

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 03/05/22, 21:02

  7. Christian Kuhn merged patch set 3 03/05/22, 21:02