Review main Merged

73829[TASK] Use GeneralUtility::trimExplode() over own solution in EXT:install

Christian Kuhn CR +2 V +2 Easy +3 −34 updated 03/05/22, 20:46

Commit message

Check->trimExplode() can be easily substituted
with GeneralUtility::trimExplode().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Christian Kuhn uploaded patch set 1 03/05/22, 20:02

  2. Christian Kuhn rebased onto patch set 2 03/05/22, 20:30

  3. Nikita Hovratov voted on patch set 2 V +1 CR +1 03/05/22, 20:36

  4. Stefan Bürk commented on patch set 2 V +1 CR +1 03/05/22, 20:36

    missing vote or failed to create pipeline for patchset 1 ?
  5. Christian Kuhn commented on patch set 2 03/05/22, 20:43

    Reply

    local unit test, functionals, cgl and phpstan are happy ... i'll merge this ... what could possibly go wrong ;)
  6. Christian Kuhn commented on patch set 2 03/05/22, 20:44

    we'll find out in nightly if we really got something wrong against all odds.
  7. core-ci voted on patch set 2 V +1 03/05/22, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24627

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 03/05/22, 20:46

  9. Christian Kuhn merged patch set 3 03/05/22, 20:46