73837[BUGFIX] Do not cast pid to int in AddRecord
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 810
-
Oli Bartsch uploaded patch set 1 03/07/22, 15:05
-
core-ci voted on patch set 1 V +1 03/07/22, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24664
-
Oliver Klee updated the commit message in patch set 2 03/07/22, 15:18
-
Oliver Klee voted on patch set 2 CR +1 03/07/22, 15:19
-
core-ci voted on patch set 2 V +1 03/07/22, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24665
-
Benni Mack voted on patch set 2 V +1 CR +1 03/07/22, 15:58
-
Nikita Hovratov commented on patch set 2 CR -1 03/07/22, 17:23
I think ###PAGE_TSCONFIG_ID### is not available in AddRecord: https://docs.typo3.org/m/typo3/reference-tca/main/en-us/ColumnsConfig/CommonProperties/FieldControl/AddRecord.html#confval-options[pid] -
Nikita Hovratov commented on patch set 2 V +1 CR +1 03/07/22, 17:40
Nevermind, all fine -
Oli Bartsch commented on patch set 2 V +2 CR +2 03/07/22, 17:42
Reply
Seems to be missing in the docs. However, it's evaluated in the AddController, see https://github.com/TYPO3/typo3/blob/4c861e36398a0780bc11cbbe1a93623ac6d9783e/typo3/sysext/backend/Classes/Controller/Wizard/AddController.php#L236 -
Oli Bartsch merged patch set 3 03/07/22, 17:42