73840[TASK] Use DependencyInjection and strict types in EXT:seo
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/seo/Classes/Canonical/CanonicalGenerator.php13+5 −28
- typo3/sysext/seo/Classes/HrefLang/HrefLangGenerator.php+4 −24
- typo3/sysext/seo/Classes/MetaTag/MetaTagGenerator.php+16 −14
- typo3/sysext/seo/Classes/XmlSitemap/AbstractXmlSitemapDataProvider.php+7 −63
- typo3/sysext/seo/Classes/XmlSitemap/PagesXmlSitemapDataProvider.php+0 −10
- typo3/sysext/seo/Classes/XmlSitemap/RecordsXmlSitemapDataProvider.php+0 −28
- typo3/sysext/seo/Classes/XmlSitemap/XmlSitemapRenderer.php+0 −17
- typo3/sysext/seo/Configuration/Services.yaml+4 −0
Review log 1216
-
Benni Mack uploaded patch set 1 03/07/22, 17:34
-
Benni Mack updated the commit message in patch set 2 03/07/22, 17:55
-
core-ci voted on patch set 1 V -1 03/07/22, 18:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24673
-
core-ci voted on patch set 2 V -1 03/07/22, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24676
-
Stefan Bürk uploaded patch set 3 03/07/22, 21:56
-
Stefan Bürk commented on patch set 3 03/07/22, 22:00
changes: * added Service.yaml entry for MetaTagGenerator (public: true) * changed HrefLangGenerator __construct() to CPP functional was in endless loop somehow and reached max execution time in CI (missing di entry). still one issue left (failing functional) - see comment in CanonicalGenerator, maybe that changed check changed the behaviour and thus the failing test ?CanonicalGenerator.php:96not sure about this change - may this be the reson for the left over failing test ? -
core-ci voted on patch set 3 V -1 03/07/22, 22:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24696
-
Benni Mack uploaded patch set 4 03/07/22, 22:37
-
core-ci voted on patch set 4 V +1 03/07/22, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24699
-
Stefan Bürk commented on patch set 4 V +1 CR +1 03/07/22, 22:50
CanonicalGenerator.php:96ReplyDone -
Benjamin Franzke commented on patch set 4 CR -1 03/08/22, 08:19
CanonicalGenerator.php:39We should avoid TSFE injection, as we marked it as a data object in v11. (we even marked injection as deprecated and I wonder why this exists at all) We should use frontend.controller request attribute if available, or fallback to GLOBALS['TSFE'] for now.CanonicalGenerator.php:41I guess this fallback is only required for unit tests. Can we adapt those?CanonicalGenerator.php:43should be injected as wellCanonicalGenerator.php:146Can RootlineUtility be injected -
Benjamin Franzke wrote 03/08/22, 08:20
Topic set to di -
Benni Mack commented on patch set 4 03/08/22, 09:11
CanonicalGenerator.php:39ReplyThis whole class is a mess, as this is using hooks, I recommend doing this in the next step: Replacing the hook with an Event that receives the Context (= thus, we can build a PageRepository), the current page, and TSFE. So "generate" doesn't do too much of the wiring itself anymore.CanonicalGenerator.php:41ReplySee above, would do this in the next step.CanonicalGenerator.php:146ReplyI fear we can't currently, but this is on the roadmap, to thin out RootLineUtility (actually "->get()" should receive $pageId and $MPvar). -
Benjamin Franzke commented on patch set 4 CR 0 03/08/22, 09:18
CanonicalGenerator.php:39ReplyAckCanonicalGenerator.php:41ReplyAckCanonicalGenerator.php:43ReplyI guess this is to be postponed to another refactoring as well then.CanonicalGenerator.php:146ReplyAck -
Benjamin Franzke voted on patch set 4 V +2 CR +2 03/10/22, 09:19
-
Benjamin Franzke merged patch set 5 03/10/22, 09:19