Review main Merged

7387[BUGFIX] TSconfig option hides table pages_language_overlay

Stefan Geith CR +2 V +2 Easy +2 −1 updated 06/03/13, 20:49

Commit message

If page TSconfig

mod.web_list.hideTranslations=*

is set, then also the table 'pages_language_overlay' is hidden,
which should be visible.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Wouter Wolters +1
    • Markus Klein +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Wouter Wolters +1
    • Markus Klein +1
    • Philipp Gampe +1

Files 1

Review log 13

  1. Markus Klein commented on patch set 2 02/08/12, 21:59

    Rebased.
  2. Markus Klein commented on patch set 2 02/08/12, 21:59

    Looks good to me, but someone else must approve
  3. Markus Klein uploaded patch set 2 02/08/12, 21:59

  4. Markus Klein uploaded patch set 3 02/08/12, 21:59

  5. Markus Klein commented on patch set 3 02/08/12, 21:59

    Verified; Looks good to me, but someone else must approve
  6. Philipp Gampe commented on patch set 3 02/08/12, 21:59

    Verified; Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 02/08/12, 21:59

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/2811/ : FAILURE
  8. Mr. Jenkins commented on patch set 2 02/08/12, 21:59

  9. Mr. Jenkins commented on patch set 3 02/08/12, 21:59

  10. Wouter Wolters commented on patch set 2 02/08/12, 21:59

    Looks good to me, but someone else must approve
  11. Wouter Wolters commented on patch set 3 02/08/12, 21:59

    Verified; Looks good to me, but someone else must approve
  12. Tolleiv Nietsch commented on patch set 3 V 0 02/08/12, 21:59

    by team member; Looks good to me, approved
  13. Tolleiv Nietsch merged patch set 3 02/08/12, 21:59