Review main Merged

73894[TASK] Remove superfluous variables from FormEngine elements

Oli Bartsch CR +2 V +2 Easy +19 −29 updated 03/15/22, 08:15

Commit message

$disabled is initialized as empty string and never
updated, before being added to the markup, thus
has no effect.

$placeholder is initialized with "0" and never updated,
thus the value can be set in the markup directly.

Additionally, this replaces a strlen() check with an empty
string comparison.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5