Review main Merged

73905[TASK] Move BE_USER check from TSFE into middleware

Benni Mack CR +2 V +2 Normal +54 −80 updated 03/14/22, 15:37

Commit message

This change moves the check if a page can be
accessed by a BE_USER and if a page is rendered
in preview, while executing a Frontend Request,
to the PSR-15 "TypoScriptFrontendInitialization"
middleware.

This way, TSFE itself does not need to know / set
any preview mechanism itself, since this is now
handled already during the Frontend Request flow.

For this reason, the "determineId()" method can
now include the logic of "fetch_the_id()",
allowing "fetch_the_id()" (protected) to be
completely removed. It's now much easier to
grasp that "determineId()" actually just
determines the final ID / Page / Rootline incl.
translations based on the given request.

This is a precursor patch to introduce new
PSR-14 events that are better suited in the
request workflow than existing hooks.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4