Review main Merged

73913[TASK] Update HTML Sanitizer

crell CR +2 V +2 Easy +10 −10 updated 11/20/22, 14:37

Commit message

The new release allows versions 1, 2, or 3 of psr/log,
so unblocks core using psr/log 3.

Commands run:
> composer req typo3/html-sanitizer ^2.0.14
> composer req typo3/html-sanitizer ^2.0.14 \
  -d typo3/sysext/core --no-update

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • crell +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1518

  1. crell uploaded patch set 1 03/14/22, 20:38

  2. core-ci voted on patch set 1 V +1 03/14/22, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24892

  3. Oliver Klee voted on patch set 1 CR +1 03/14/22, 23:17

  4. Simon Schaufelberger voted on patch set 1 V +1 CR +1 03/15/22, 00:30

  5. Benjamin Franzke commented on patch set 1 CR -1 03/15/22, 05:19

    Please also backport to v11 (add an appropriate Releases line), or is there a reason not to backport?
  6. crell commented on patch set 1 03/15/22, 19:58

    Reply

    I think the only change from v1.0.13 to .14 was changing the psr/log versions. The v2 and v3 versions require PHP 8.x anyway, though, so that part isn't backportable to v11 anyway. So, at least for the scope I have in mind there's no reason to backport. (There may be other reasons, but they're separate from my intent here.)
  7. Stefan Bürk commented on patch set 1 CR -1 03/16/22, 14:35

    Reply

    v11 also uses "^2.0.11" .. and "https://packagist.org/packages/typo3/html-sanitizer":"^2.0.14"; is php:"^7.2 || ^8.0". So I'm here with Benjamin, we should add the backport for it. to have a similar min version constraint which is possible in this case. See: https://packagist.org/packages/typo3/html-sanitizer
  8. Stefan Bürk updated the commit message in patch set 2 03/16/22, 14:35

  9. Oliver Klee voted on patch set 2 CR +1 03/16/22, 14:42

  10. core-ci voted on patch set 2 V -1 03/16/22, 14:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24947

  11. core-ci voted on patch set 2 V +1 03/16/22, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24947

  12. Stefan Bürk voted on patch set 2 V +1 CR +1 03/16/22, 15:00

  13. crell voted on patch set 2 CR +1 03/16/22, 19:57

  14. Nikita Hovratov voted on patch set 2 V +1 CR +1 03/17/22, 18:18

  15. Oli Bartsch voted on patch set 2 V +1 CR +1 03/17/22, 21:46

  16. Benni Mack voted on patch set 2 V +2 CR +2 03/21/22, 12:00

  17. Benni Mack merged patch set 3 03/21/22, 12:00

  18. Christian Kuhn commented on patch set 3 11/20/22, 14:37