Review main Merged

73978[BUGFIX] Prevent TypeError for unsupported operand types

Oli Bartsch CR +2 V +2 Easy +3 −8 updated 03/21/22, 15:21

Commit message

Since bitwise operators requires the operands to be
integers, a possible raw database value for a checkbox
element is now properly casted, before used as operand,
preventing a TypeError.

Note: PHP < 8, this only triggered a warning.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 912

  1. Oli Bartsch uploaded patch set 1 03/16/22, 17:14

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 03/16/22, 17:17

  3. Stefan Bürk uploaded patch set 2 03/16/22, 17:21

  4. core-ci voted on patch set 2 V -1 03/16/22, 17:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24950

  5. core-ci voted on patch set 1 V -1 03/16/22, 17:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24949

  6. core-ci voted on patch set 2 V +1 03/16/22, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24950

  7. Stefan Bürk commented on patch set 2 V +1 CR +1 03/16/22, 17:41

    patchset 1: phpstan error patchset 2: fail was because of docker/network issue, restart of test green
  8. Oliver Klee voted on patch set 2 CR +1 03/16/22, 18:29

  9. Nikita Hovratov voted on patch set 2 V +1 CR +1 03/18/22, 20:58

  10. Benni Mack voted on patch set 2 V +1 CR +1 03/21/22, 11:36

  11. Oli Bartsch voted on patch set 2 V +2 CR +2 03/21/22, 15:21

  12. Oli Bartsch merged patch set 3 03/21/22, 15:21