Review main Merged

73979[BUGFIX] Fix PHP deprecation on retrieving file / folder object

TYPO3com CR +2 V +2 Easy +1 −1 updated 03/16/22, 22:21

Commit message

Since PHP 8.1, passing null to non-nullable internal function
parameters is deprecated. Therefore the str_replace() call in
ResourceFactory:retrieveFileOrFolderObject() might trigger a
PHP deprecation.

This is now fixed by adding a typecast to the input value.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. TYPO3com uploaded patch set 1 03/16/22, 18:31

  2. core-ci voted on patch set 1 V +1 03/16/22, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24951

  3. Oli Bartsch updated the commit message in patch set 2 03/16/22, 21:10

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 03/16/22, 21:12

  5. core-ci voted on patch set 2 V +1 03/16/22, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24954

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 03/16/22, 21:33

  7. Oli Bartsch updated the commit message in patch set 3 03/16/22, 21:38

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 03/16/22, 21:38

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 03/16/22, 21:39

  10. core-ci voted on patch set 3 V +1 03/16/22, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24955

  11. Oli Bartsch voted on patch set 3 V +2 CR +2 03/16/22, 22:20

  12. Oli Bartsch merged patch set 4 03/16/22, 22:21