Review main Abandoned Breaking

73989[!!!][TASK] Add native typing for more Utility classes

crell CR 0 V 0 Hard +230 −397 updated 04/13/22, 16:48

Commit message

Adds native types for CsvUtility.
Adds native types for DebugUtility.
Adds native types for DiffUtility.
Adds native types for ExtensionManagementUtility.
Add native types for HttpUtility.
Add native types for MailUtility.

DiffUtility had some interesting interactions around nulls, as some
parameters were docblock-typed for string but occaionally called
with null, specifically from debug().  I fixed that by normalizing
to a string inside debug().

I also improved the documentation for renderDump(), which had
silently nullable booleans without explaining why, but changing it
to non- nullable broke. I added to the documentation to better
explain why.

The one change to BackendUtility is because getProcessedValue()'s
result gets passed directly to DiffUtility::makeDiffDisplay()
by ImportExport. However, it's of undefined type while
DiffDisplay() wants a string only, so it was somehow passing
an integer through. For now, since BackendUtility is in weak
type mode just specifying a return type seems to fix the issue.
That will have to get cleaned up further at some point later.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 11