Review main Merged

74021[BUGFIX] Avoid PHP 8.x error in RecordHistory if BE user is missing

Jan Helke CR +2 V +2 Easy +2 −2 updated 03/28/22, 08:44

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Jan Helke uploaded patch set 1 03/23/22, 07:10

  2. core-ci voted on patch set 1 V +1 03/23/22, 07:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25070

  3. Stefan Bürk commented on patch set 1 03/23/22, 07:29

    ElementHistoryController.php:288

    Should we really leave this empty ? Okay, that's the same behaviour as in php <8.0, but not really user friendly. Maybe something like "deleted" or not "not existing anymore" (translated) would be more noticable in the backend / history view. Better than "empty". Same for original user below .... Maybe doing it as bugfix this way and at least fix this with a fallbcack output in main. (Not sure about backport policy with new languge strings).
  4. Oli Bartsch commented on patch set 1 03/23/22, 09:23

    ElementHistoryController.php:288 Reply

    Or maybe "[Not found]"?
  5. Jan Helke commented on patch set 1 03/23/22, 09:24

    ElementHistoryController.php:288 Reply

    I thought about it, but as this is a pure bugfix we shouldn't try to introduce new stuff.
  6. Oliver Klee voted on patch set 1 CR +1 03/23/22, 12:42

  7. Oli Bartsch commented on patch set 1 V +1 CR +1 03/28/22, 08:41

    ElementHistoryController.php:288 Reply

    Ok, let's go with this. I'll then add a follow up patch based on this one.
  8. Stefan Bürk commented on patch set 1 V +1 CR +1 03/28/22, 08:42

    ElementHistoryController.php:288 Reply

    Ack.
  9. Oli Bartsch voted on patch set 1 V +2 CR +2 03/28/22, 08:42

  10. Oli Bartsch merged patch set 2 03/28/22, 08:44