Review main Merged

74029[BUGFIX] Properly add crop variants parameter to preview url

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 03/25/22, 09:55

Commit message

Using the hook
['Backend/Form/Element/ImageManipulationElement']['previewUrl'],
one can define a preview url for the image
manipulation wizard. If defined, a button
is displayed, opening the defined url in a
new window, while adding the crop variants
as an additional query parameter.

However, the query parameter was previously
always added using "&" which failed, in case
the defined preview url does not already define
query parameters.

This is now fixed by properly checking whether
the url already contains further parameters when
adding the crop variants.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2