Review main Abandoned Breaking

74052[!!!][TASK] Remove exclude setting from important TCA fields

Georg Ringer CR 0 V 0 Normal +142 −53 updated 02/03/25, 19:53

Commit message

To simplify the permission setup and to harmonize the TCA, the setting
`exclude => true` is remove from the following fields:

- `$GLOBALS['TCA'][$table]['ctrl']['typeicon_column']`
- `$GLOBALS['TCA'][$table]['ctrl']['languageField']`

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 38

Show 18 more files

Review log 2942

Show 1217 earlier messages
  1. Georg Ringer uploaded patch set 1 03/25/22, 08:21

  2. Georg Ringer commented on patch set 1 03/25/22, 08:21

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 03/25/22, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25124

  4. Benni Mack commented on patch set 1 03/25/22, 11:16

    Is this a task or a feature or?
  5. Tymoteusz Motylewski commented on patch set 1 03/26/22, 20:16

    Breaking-97238-RemoveExcludeSettingFromSomeTCAFields.rst:14 Unresolved

    has been removed
  6. Georg Ringer uploaded patch set 2 04/02/22, 06:49

  7. core-ci voted on patch set 2 V +1 04/02/22, 06:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25366

  8. Oliver Klee voted on patch set 2 CR +1 04/02/22, 09:59

  9. Benni Mack commented on patch set 2 04/05/22, 17:05

    I suggest that we have a TCA migration to remove exclude fields for ALL tables - namely "typeColumn", "sys_language_uid" and "l10n_parent". Cool with you Georg?
  10. Georg Ringer uploaded patch set 3 05/09/22, 12:57

  11. Georg Ringer commented on patch set 3 05/09/22, 12:57

    Reply

    also fine for me
  12. Oliver Klee voted on patch set 3 CR +1 05/09/22, 13:00

  13. core-ci voted on patch set 3 V -1 05/09/22, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27027

  14. Georg Ringer uploaded patch set 4 05/09/22, 13:24

  15. core-ci voted on patch set 4 V -1 05/09/22, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27030

  16. Georg Ringer uploaded patch set 5 05/09/22, 17:34

  17. core-ci voted on patch set 5 V -1 05/09/22, 17:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27042

  1. Georg Ringer rebased onto patch set 6 05/09/22, 20:04

  2. core-ci voted on patch set 6 V -1 05/09/22, 20:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27052

  3. Georg Ringer uploaded patch set 7 05/10/22, 04:45

  4. core-ci voted on patch set 7 V -1 05/10/22, 04:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27071

  5. Georg Ringer uploaded patch set 8 05/10/22, 04:54

  6. core-ci voted on patch set 8 V +1 05/10/22, 05:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27072

  7. Georg Ringer uploaded patch set 9 05/11/22, 05:22

  8. core-ci voted on patch set 9 V +1 05/11/22, 05:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27112

  9. Benni Mack commented on patch set 9 05/11/22, 06:49

    TcaMigration.php:274

    should we also include the "editLock" field?
  10. Georg Ringer commented on patch set 9 05/11/22, 10:28

    IMO editlock is a bit different as it would be good to force a display_cond
  11. Georg Ringer rebased onto patch set 10 06/02/22, 06:34

  12. core-ci voted on patch set 10 V +1 06/02/22, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27642

  13. Christian Kuhn uploaded patch set 11 07/31/22, 11:45

  14. Christian Kuhn commented on patch set 11 07/31/22, 11:46

    rebased. will do an in-depth review soon.
  15. core-ci voted on patch set 11 V -1 07/31/22, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29754

  16. Christian Kuhn commented on patch set 11 CR -1 08/13/22, 06:40

    -1 for now. i think we should sort out some details.

    pages.php:72

    this one needs to be discussed: do we really want to no longer allow non-admins setting a page to a different doktype? the .rst currently says: Fields configured in :php:`$GLOBALS['TCA'][$table]['ctrl']['typeicon_column']` and :php:`$GLOBALS['TCA'][$table]['ctrl']['languageField']` are now always visible for every editor and can't be forgotten during setup of the permissions. this is *not* true for typeicon_column (doktype in pages): with applied patch and saving a be_group that had doktype exclude set for pages, it is removed from the exclude list, and an editor can't see the field anymore, the type drop-down is then gone when editing a page. this also means, that *if* we go this path, we may need an upgrade wizard to actively remove the field from any be_groups access list fields? maybe it would be easier to at least split this field out-of the patch and make it a dedicated patch to decide on details?

    Breaking-97238-RemoveExcludeConfigurationFromImportantFields.rst:24

    See my other comment for typeicon_column. For 'languageField': I can't find code that ensures the type=language / ctrl['languageField'] field is always shown to editors. i played around on tt_content and was indeed unable to make the select drop-down vanish for users, but didn't find the code that takes care of this in formEngine and list module. Where is this ensured? If this is sorted out, then removing exclude=true from languageField columns is of course ok and it would be pretty much a follow-up to the type=language tca type introduction? The main issue is deeper here: be_users should typically never fiddle with sys_language_uid on existing records, and set them into a different language, since this easily destroys integrity of other related fields like l10n_source and similar. I'd say the only reason we didn't restrict this yet is the '-1' value, which wouldn't be able to be set then, anymore, if we don't show that field in FormEngine anymore. However, mid-term, we should find a better solution for '-1', make DataHandler handle it it a good way without destroying integrity, and then remove the language select drop down from FormEngine. So for now, I'd be +1 with removing exclude=1 from ctrl-languageField / type=language columns, as long as we verified (list + formEngine) that it for now is indeed always rendered.
  17. Georg Ringer rebased onto patch set 12 09/28/22, 06:13

  18. core-ci voted on patch set 12 V -1 09/28/22, 06:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31630

  19. Georg Ringer uploaded patch set 13 09/30/22, 06:07

  20. core-ci voted on patch set 13 V +1 09/30/22, 06:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31737

  21. Benni Mack commented on patch set 13 10/02/22, 08:04

    TcaMigration.php:274 Reply

    Done

    pages.php:72 Reply Unresolved

    I think in this case this is valid, as we also use be_groups.pagetypes_select (boy oh how I hate this name), which is actually used to configure things properly within THAT field itself.

    Breaking-97238-RemoveExcludeConfigurationFromImportantFields.rst:24 Reply

    yes. I agree here, we should move forward with the long-term strategy on sys_language_uid and l10n_parent being handled in a special manner.
  22. Oliver Klee commented on patch set 13 10/08/23, 13:43

    How should we proceed here?
  23. Simon Schaufelberger commented on patch set 13 01/25/24, 14:27

    Reply Unresolved

    @georg.ringer@gmail.com Will this make it for v13?
  24. Benni Mack wrote 01/25/24, 15:25

    Removed reviewer Benni Mack.
  25. Georg Ringer abandoned the change 02/03/25, 19:53

    i am abandon that one now, seems not to get any consent