Review main Merged

74053[TASK] Migrate tasks to native tasks

Georg Ringer CR +2 V +2 Hard +438 −212 updated 10/02/25, 20:15

Commit message

All tasks that have been registered via

"$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks']"
are now migrated to "native scheduler tasks",
which means

a) they are registered as extra "tasktype"
   of the now available TCA "tx_scheduler_task"

b) their fields have been migrated to custom fields
   if there were any.

The AdditionalFieldProviderInterface is deprecated.

This patch migrates the last remaining EXT:reports system status
task, see related issues for other migrations.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 5

Files 16

Review log 99165

Show 84140 earlier messages
  1. Georg Ringer uploaded patch set 1 03/25/22, 09:12

  2. core-ci voted on patch set 1 V -1 03/25/22, 09:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25126

  3. Georg Ringer uploaded patch set 2 03/25/22, 10:33

  4. core-ci voted on patch set 2 V -1 03/25/22, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25133

  5. Georg Ringer uploaded patch set 3 03/25/22, 11:43

  6. core-ci voted on patch set 3 V -1 03/25/22, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25134

  7. Georg Ringer uploaded patch set 4 03/26/22, 10:19

  8. core-ci voted on patch set 4 V -1 03/26/22, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25174

  9. Georg Ringer uploaded patch set 5 03/26/22, 10:35

  10. core-ci voted on patch set 5 V -1 03/26/22, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25175

  11. Georg Ringer uploaded patch set 6 03/26/22, 11:15

  12. core-ci voted on patch set 6 V -1 03/26/22, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25176

  13. Georg Ringer uploaded patch set 7 03/30/22, 09:26

  14. core-ci voted on patch set 7 V -1 03/30/22, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25281

  15. Georg Ringer uploaded patch set 8 04/02/22, 08:36

  16. Georg Ringer uploaded patch set 9 04/02/22, 08:37

  17. core-ci voted on patch set 8 V -1 04/02/22, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25368

  18. core-ci voted on patch set 9 V -1 04/02/22, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25369

  19. Georg Ringer uploaded patch set 10 04/02/22, 09:10

  20. core-ci voted on patch set 10 V -1 04/02/22, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25370

  21. Georg Ringer uploaded patch set 11 04/02/22, 09:33

  22. core-ci voted on patch set 11 V -1 04/02/22, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25371

  23. Georg Ringer uploaded patch set 12 04/02/22, 10:15

  24. core-ci voted on patch set 12 V -1 04/02/22, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25372

  25. Georg Ringer uploaded patch set 13 04/02/22, 12:50

  26. core-ci voted on patch set 13 V -1 04/02/22, 13:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25373

  27. Georg Ringer uploaded patch set 14 04/02/22, 15:35

  28. core-ci voted on patch set 14 V -1 04/02/22, 15:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25374

  29. Georg Ringer uploaded patch set 15 04/02/22, 16:02

  30. Georg Ringer uploaded patch set 16 04/02/22, 16:12

  31. core-ci voted on patch set 15 V -1 04/02/22, 16:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25375

  32. core-ci voted on patch set 16 V -1 04/02/22, 16:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25376

  33. Benni Mack uploaded patch set 17 06/21/22, 10:48

  34. core-ci voted on patch set 17 V -1 06/21/22, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28296

  35. Georg Ringer uploaded patch set 18 06/21/22, 19:40

  36. core-ci voted on patch set 18 V -1 06/21/22, 19:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28308

  37. Georg Ringer uploaded patch set 19 09/27/22, 13:14

  38. core-ci voted on patch set 19 V -1 09/27/22, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31592

  39. Georg Ringer uploaded patch set 20 09/27/22, 14:13

  40. core-ci voted on patch set 20 V -1 09/27/22, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31596

  41. Georg Ringer uploaded patch set 21 09/27/22, 15:10

  42. core-ci voted on patch set 21 V -1 09/27/22, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31600

  43. Georg Ringer uploaded patch set 22 09/27/22, 15:46

  44. core-ci voted on patch set 22 V -1 09/27/22, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31601

  45. Georg Ringer uploaded patch set 23 09/27/22, 16:21

  46. core-ci voted on patch set 23 V -1 09/27/22, 16:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31602

  47. Georg Ringer uploaded patch set 24 09/27/22, 18:00

  48. core-ci voted on patch set 24 V -1 09/27/22, 18:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31612

  49. Georg Ringer uploaded patch set 25 09/27/22, 19:00

  50. core-ci voted on patch set 25 V +1 09/27/22, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31614

  51. Georg Ringer uploaded patch set 26 09/27/22, 20:34

  52. Georg Ringer commented on patch set 26 09/27/22, 20:41

    This change is ready for review.
  53. core-ci voted on patch set 26 V -1 09/27/22, 20:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31617

  54. Georg Ringer commented on patch set 27 09/27/22, 21:22

    Published edit on patch set 26.
  55. core-ci voted on patch set 27 V +1 09/27/22, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31618

  56. Simon Schaufelberger commented on patch set 27 CR -1 09/27/22, 23:48

    BrokenLinkRepository.php:78

    remove

    BrokenLinkRepository.php:133

    don't touch this file

    SystemStatusUpdateCommand.php:98

    I personally would prefer to put that into a fluid template instead of putting the message in php together. it's not a request to change that but just an idea

    IpAnonymizationCommand.php:54

    is encoding the & necessary here?
  57. Benni Mack uploaded patch set 28 10/01/22, 08:48

  58. core-ci voted on patch set 28 V -1 10/01/22, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31809

  59. Simon Schaufelberger commented on patch set 28 06/29/23, 05:26

    There are a lot of merge conflicts now. Is this patch still relevant?
  60. Georg Ringer commented on patch set 28 06/29/23, 19:59

    yes it is
  61. Simon Schaufelberger commented on patch set 28 06/29/23, 23:36

    Reply

    ok. would you be able to rebase this patch? Lots of things have changed in the meantime.
  62. Georg Ringer uploaded patch set 29 V -1 07/12/23, 18:08

  63. core-ci voted on patch set 29 V -1 07/12/23, 18:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44093

  64. Anja Leichsenring uploaded patch set 30 V -1 08/02/23, 15:45

  65. core-ci voted on patch set 30 V -1 08/02/23, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44898

  66. Anja Leichsenring commented on patch set 30 V -1 08/02/23, 16:09

    I messed the rebase ab badly, but will fix it again. This only needs a little time.
  67. Anja Leichsenring commented on patch set 30 08/02/23, 16:15

    Reply

    yeah, that's the way. Messed up the message, too. Will fix anyway, but tomorrow.
  68. Simon Schaufelberger commented on patch set 30 12/22/23, 01:23

    Reply

    ping
  69. Simon Schaufelberger commented on patch set 30 01/25/24, 14:18

    Reply

    @georg.ringer@gmail.com will this patch make it for v13?
  70. Anja Leichsenring commented on patch set 30 01/31/24, 10:27

    I am working on it
  71. Anja Leichsenring uploaded patch set 31 V -1 02/01/24, 13:08

  72. Anja Leichsenring uploaded patch set 32 02/01/24, 13:10

  73. core-ci voted on patch set 31 V -1 02/01/24, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52587

  74. core-ci voted on patch set 32 V -1 02/01/24, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52588

  75. Anja Leichsenring uploaded patch set 33 V -1 02/01/24, 13:23

  76. core-ci voted on patch set 33 V -1 02/01/24, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52589

  77. Anja Leichsenring uploaded patch set 34 V -1 02/01/24, 14:20

  78. core-ci voted on patch set 34 V -1 02/01/24, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52593

  79. Anja Leichsenring uploaded patch set 35 V -1 02/01/24, 14:29

  80. core-ci voted on patch set 35 V -1 02/01/24, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52594

  81. Anja Leichsenring uploaded patch set 36 V -1 02/01/24, 14:35

  82. Anja Leichsenring uploaded patch set 37 02/01/24, 14:39

  83. core-ci voted on patch set 36 V -1 02/01/24, 14:42 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 37 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52595

  84. Anja Leichsenring uploaded patch set 38 V -1 02/01/24, 14:44

  85. core-ci voted on patch set 37 V -1 02/01/24, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52596

  86. Anja Leichsenring uploaded patch set 39 02/01/24, 14:50

  87. core-ci voted on patch set 38 V -1 02/01/24, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52598

  88. core-ci voted on patch set 39 V +1 02/01/24, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52599

  89. Sebastian Iffland commented on patch set 39 02/01/24, 15:08

    UpdateExtensionListCommand.php:36

    I'd guess a type-cast to bool is required according to return type. EC->get() returns mixed.
  90. Anja Leichsenring rebased onto patch set 40 V +1 02/04/24, 04:50

  91. core-ci voted on patch set 40 V +1 02/04/24, 04:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52679

  92. Anja Leichsenring rebased onto patch set 41 V +1 02/13/24, 13:00

  93. core-ci voted on patch set 41 V +1 02/13/24, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53169

  94. Andreas Kienast commented on patch set 41 CR -1 02/13/24, 13:09

    ValidateCommand.php:105

    Please use `Command::*` constants. Also, this case doesn't qualify as being successful.

    ValidateCommand.php:110

    This case doesn't qualify as being successful.

    CleanerCommand.php:80

    Please use `Command::*` constants. Also, this case doesn't qualify as being successful.

    CachingFrameworkGarbageCollectionCommand.php:74

    Please use `Command::*` constants. Also, this case doesn't qualify as being successful.

    FileStorageExtractionCommand.php:82

    Please use `Command::*` constants. Also, this case doesn't qualify as being successful.

    FileStorageIndexingCommand.php:81

    Please use `Command::*` constants. Also, this case doesn't qualify as being successful.

    IpAnonymizationCommand.php:77

    Please use `Command::*` constants. Also, this case doesn't qualify as being successful.

    IpAnonymizationCommand.php:81

    Please use `Command::*` constants. Also, this case doesn't qualify as being successful.

    IpAnonymizationCommand.php:85

    Please use `Command::*` constants. Also, this case doesn't qualify as being successful.

    IpAnonymizationCommand.php:92

    Please use `Command::*` constants. Also, this case doesn't qualify as being successful.

    TableGarbageCollectionCommand.php:75

    Please use `Command::*` constants. Also, this case doesn't qualify as being successful.
  95. Mathias Brodala commented on patch set 41 02/13/24, 13:37

    Feature-98453-MigrationOfTasksToCommands.rst:30

    Can we list all command names here, too. This allows for easier reference/copy-paste.
  96. Garvin Hicking commented on patch set 41 02/13/24, 19:16

    UpdateExtensionListCommand.php:36 Reply

    I also got a PHP error when running `vendor/bin/typo3 cache:flush` there: Uncaught TYPO3 Exception TYPO3\CMS\Extensionmanager\Command\UpdateExtensionListCommand::isEnabled(): Return value must be of type bool, string returned thrown in file /var/www/html/typo3-core/typo3/sysext/extensionmanager/Classes/Command/UpdateExtensionListCommand.php in line 37
  97. Garvin Hicking commented on patch set 41 CR -1 02/14/24, 07:44

    On it to improve labels and some docs
  98. Garvin Hicking uploaded patch set 42 CR -1 V +1 02/14/24, 13:17

    Localization and a few fixes
  99. Garvin Hicking commented on patch set 42 02/14/24, 13:21

    I've addressed a few things: * Renamed Deprecation entry (98453 instead of 93453, typo) * Added copy+paste able list of new CLI commands to RST * Sorted list of new Commands alphabetically * Small wording change in the ReSTs * Fixed error in UpdateExtensionListCommand for a (bool) cast that prevented further operation * Added "lineFeedToArray" for the upgrade wizard to the "email" argument of the ValidateCommand so that multiple values are imported * Fixed upgrade wizard to enable the "[x] Add option" flag for all converted options, else they were not used anymore (and fallback to defaults) * Moved hardcoded strings to correspondig locallang entries where applicable. Only a few hardcoded strings remain where I think distinct keys are not that important. Focus was to allow the scheduler backend module a fully localized view. * Enhanced labels for options that allow to specify boolean/specific values, so that the GUI now indicates if "1" is enabled and "0" disabled * Replaced "return 0" with "return Command::FAILURE" * Added a verbose output for list of cleared cache framework identifiers and list of available anonymization and garbage collection tables (previous Tasks had multiselects to indicate this) * Fixed a bug in the IpAnyomyization which relied on a TCA entry for sys_log, which does not exist * Fixed missing backport of MySQL/MariaDB distinction due to doctrine DBAL (the migrated task was still dated from 2022 and was missing a bit of adaptation - seems as if that Command luckily was the only outdated one) * Adapted the scheduler backend GUI so that for array-values it shows "Add option (multiple values separated by a comma)" to easily spot which options allow multiple inputs One issue remains that I think is important to discuss. Options all are shown as a "input" single line input field. That works for 99% of all the converted tasks, but for the EXT:linkvalidator:validate one there's a large "TSconfig" input which will most likely contain large amounts of text. We cannot implode that with "," as we do with i.e. emails, because that would later break TSconfig (when it is joined on a single line). I think we can only work this out by providing a textarea input to the scheduler backend module. Sadly, we cannot decorate the "InputOption" easily with an attribute that indicates "this option should be rendered as a textarea". I have several ideas on how we could bypass that: - Fixed suffixes like "_textarea" to a config option - abuse the "autocompletion" option; if that is set, a textarea will be utilized - Add a magic marker in the description of a command (i.e. "[textarea]"). - Use TSconfig to configure this within the ExecuteSchedulableCommandAdditionalFieldProvider - Actually drop "TSconfig" from the GUI and state something like: "You can only use a single line as input; if you need to specify a larger block of TSconfig code, you can use the typo3 console interface instead." I don't really like like any of these solutions. :-/

    Feature-98453-MigrationOfTasksToCommands.rst:30 Reply

    Done

    UpdateExtensionListCommand.php:36 Reply

    Done

    ValidateCommand.php:105 Reply

    Done

    ValidateCommand.php:110 Reply

    Done

    CleanerCommand.php:80 Reply

    Done

    SystemStatusUpdateCommand.php:98 Reply

    Since the scope of this patch is already quite impactful and large, maybe we could address this better in a follow-up PR?

    CachingFrameworkGarbageCollectionCommand.php:74 Reply

    Done

    FileStorageExtractionCommand.php:82 Reply

    Done

    FileStorageIndexingCommand.php:81 Reply

    Done

    IpAnonymizationCommand.php:54 Reply

    Done

    IpAnonymizationCommand.php:77 Reply

    Done

    IpAnonymizationCommand.php:81 Reply

    Done

    IpAnonymizationCommand.php:85 Reply

    Done

    IpAnonymizationCommand.php:92 Reply

    Done

    TableGarbageCollectionCommand.php:75 Reply

    Done
  100. Garvin Hicking commented on patch set 42 02/14/24, 13:22

    Reply

    Done

    Reply

    Done

    Reply

    Done

    Reply

    Done

    BrokenLinkRepository.php:78 Reply

    Done

    BrokenLinkRepository.php:133 Reply

    Done
  101. core-ci voted on patch set 42 V +1 02/14/24, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53194

  102. Garvin Hicking uploaded patch set 43 V +1 04/05/24, 13:05

  103. core-ci voted on patch set 43 V +1 04/05/24, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55384

  104. Garvin Hicking uploaded patch set 44 V +1 05/25/24, 23:17

    Rebase and fix merge conflict
  105. core-ci voted on patch set 44 V +1 05/25/24, 23:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58232

  106. Garvin Hicking uploaded patch set 45 V +1 05/25/24, 23:23

    Move RST and document open issue
  107. core-ci voted on patch set 45 V +1 05/25/24, 23:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58233

  108. Garvin Hicking commented on patch set 45 05/27/24, 05:03

    SystemStatusUpdateCommand.php:98 Reply

    Acknowledged
  109. Garvin Hicking uploaded patch set 46 V +1 06/14/24, 15:48

    rebase
  110. core-ci voted on patch set 46 V +1 06/14/24, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59609

  111. Garvin Hicking rebased onto patch set 47 V +1 07/23/24, 11:20

  112. core-ci voted on patch set 47 V +1 07/23/24, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62005

  113. Anja Leichsenring commented on patch set 47 CR +1 V +1 08/01/24, 09:50

    finally that works. I tested on a basic setup, but had no evidence of failure. Let's get that one in!
  114. Georg Ringer commented on patch set 47 08/01/24, 11:01

    can someone move the rst files into the 13.3 dir?
  115. Anja Leichsenring uploaded patch set 48 CR +1 V +1 08/01/24, 12:16

  116. Anja Leichsenring voted on patch set 48 CR +1 V +1 08/01/24, 12:17

  117. core-ci voted on patch set 48 V -1 08/01/24, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62589

  118. core-ci voted on patch set 48 V +1 08/01/24, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62589

  119. Garvin Hicking commented on patch set 48 08/01/24, 13:20

    Note to self: Add a @todo in EXT:linkvalidator:validate that mentions the "textarea" problem, and that we cannot remove that scheduler task in v14 without creating a solution. That solution is outside the scope of this patch.
  120. Garvin Hicking uploaded patch set 49 CR +1 V +1 08/02/24, 20:05

    Add todo
  121. Garvin Hicking commented on patch set 49 CR +1 V +1 08/02/24, 20:06

    Reply

    Done
  122. core-ci voted on patch set 49 V +1 08/02/24, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62768

  123. Garvin Hicking commented on patch set 49 08/21/24, 19:36

    lolli, Anja and me discussed this today and we see a problem with scope/vision. The CLI command settings interface may collide with what is currently planned with Site Set Settings API, which also addresses several other places of settings. Since the LinkValidatorTask makes trouble with the large textarea blob, a solution for that might need to be found for a new Settings API/GUI. If we migrate all tasks to commands at this point (while also still having Tasks around), we might work ourselves into a corner. We could split this patch into two or three parts: 1.) Introduce all functionality as Commands 2.) Deprecate existing tasks 3.) Migration wizards to migrate tasks into commands Due to the upcoming feature freeze and the imminence of the Settings API, we might want to delay this? (I'm leaving my vote as-is because I believe this is a 90% solution, with follow-up potential, so that other Mergers can weigh in)
  124. Georg Ringer uploaded patch set 50 CR +1 V +1 01/22/25, 21:01

  125. core-ci voted on patch set 50 V -1 01/22/25, 21:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72885

  126. Garvin Hicking uploaded patch set 51 V -1 02/03/25, 11:59

    Fix PHPStan complain
  127. core-ci voted on patch set 51 V -1 02/03/25, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73387

  128. Garvin Hicking uploaded patch set 52 V -1 02/03/25, 12:40

    Bypass acceptance test failure
  129. core-ci voted on patch set 52 V +1 02/03/25, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73397

  130. Benni Mack commented on patch set 52 03/27/25, 17:38

    marking this one as WIP until we've moved forward with the other patches first
  131. Benni Mack marked it work in progress 03/27/25, 17:39

  132. Garvin Hicking commented on patch set 52 03/27/25, 18:48

    Reply

    Discussion from #106062: a) change the "let's serialize the objects" -- see https://review.typo3.org/c/Packages/TYPO3.CMS/+/88675 b) add TCA for scheduler tasks -> then change the rendering, add TCA types for it c) migrate additional field providers as additional fields of a task in the DB (or type=json) with type=user rendering. d) see what should be migrated to a CLI command (where it makes sense) and what should just stay a scheduler task (in a simple way) -> this is the point where we should talk about multiline arguments... :)
  133. Benni Mack uploaded patch set 53 V +1 09/25/25, 14:12

  134. Benni Mack commented on patch set 54 09/25/25, 14:13

    Published edit on patch set 53.
  135. core-ci voted on patch set 54 V -1 09/25/25, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85527

  136. core-ci voted on patch set 53 V -1 09/25/25, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85526

  137. Benni Mack updated the commit message in patch set 55 V -1 10/01/25, 13:37

  138. core-ci voted on patch set 55 V -1 10/01/25, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85820

  139. Benni Mack marked it ready for review 10/02/25, 09:27

  140. Oli Bartsch uploaded patch set 56 V -1 10/02/25, 10:07

  1. core-ci voted on patch set 56 V -1 10/02/25, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85896

  2. Benni Mack uploaded patch set 57 V -1 10/02/25, 10:26

  3. Benni Mack commented on patch set 57 10/02/25, 10:27

    Reply

    we're there!

    Reply

    Done
  4. Benni Mack commented on patch set 57 10/02/25, 10:27

    Reply

    Done
  5. Benni Mack uploaded patch set 58 10/02/25, 10:29

  6. core-ci voted on patch set 57 V -1 10/02/25, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85899

  7. core-ci voted on patch set 58 V -1 10/02/25, 10:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85900

  8. Garvin Hicking updated the commit message in patch set 59 V -1 10/02/25, 11:25

  9. Garvin Hicking commented on patch set 60 10/02/25, 11:32

    Published edit on patch set 59.
  10. core-ci voted on patch set 59 V -1 10/02/25, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85911

  11. core-ci voted on patch set 60 V -1 10/02/25, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85912

  12. Oli Bartsch uploaded patch set 61 V -1 10/02/25, 14:12

  13. core-ci voted on patch set 61 V -1 10/02/25, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85923

  14. Oli Bartsch uploaded patch set 62 V -1 10/02/25, 14:24

  15. Oli Bartsch commented on patch set 63 10/02/25, 14:26

    Published edit on patch set 62.
  16. core-ci voted on patch set 62 V +1 10/02/25, 14:31 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 63 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85925

  17. core-ci voted on patch set 63 V +1 10/02/25, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85926

  18. Oli Bartsch uploaded patch set 64 V +1 10/02/25, 14:34

  19. Garvin Hicking commented on patch set 64 10/02/25, 14:37

    Great documentation additions, thanks Oli! This will make it very easy for the docs.typo3.org adoption <3

    TaskService.php:228

    ```suggestion $taskInformation['provider'] . ' is using AdditionalFieldProviderInterface, which is deprecated and will be removed in TYPO3 v15.0. Use native TCA-based scheduler tasks instead.', ```
  20. core-ci voted on patch set 64 V +1 10/02/25, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85927

  21. Garvin Hicking commented on patch set 65 V +1 10/02/25, 14:50

    Published edit on patch set 64.
  22. Garvin Hicking commented on patch set 65 CR +1 V +1 10/02/25, 14:51

    TaskService.php:228 Reply

    Done
  23. core-ci voted on patch set 65 V +1 10/02/25, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85928

  24. Georg Ringer voted on patch set 65 CR +2 V +2 10/02/25, 20:15

  25. Georg Ringer merged patch set 66 10/02/25, 20:15