Review main Merged

74063[TASK] Update dependency to PSR-3 v2/3

crell CR +2 V +2 Easy +22 −19 updated 03/27/22, 20:25

Commit message

PSR-3 v2 and v3 add types, so we can switch to those now.

Because we don't fully implement PSR-3 directly, this is
a trivial change. Most of the updates are in tests and
nominally optional.

Note that composer/composer is still only v2 compatible,
not v3, so this will still only pull in v2. However, it
sets us up to automatically and safely get v3 as soon as
composer/composer is updated.

AbstractLogger is also now vestigial (it does nothing but
use LoggerTrait), so I've removed usage of it in favor of
the trait. That eliminates one autoload lookup.

Used commands:

> composer req psr/log:"^2.0 || ^3.0"
> composer req psr/log:"^2.0 || ^3.0" \
  -d typo3/sysext/core --no-update
> composer req psr/log:"^2.0 || ^3.0" \
  -d typo3/sysext/redirects --no-update

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 911

  1. crell uploaded patch set 1 03/25/22, 19:06

  2. core-ci voted on patch set 1 V +1 03/25/22, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25152

  3. Oliver Klee commented on patch set 1 03/25/22, 19:54

    composer.json:24

    For consistency, please let’s use the double pipe ||, and please let’s put spaces around it (also in the other composer.json).
  4. Stefan Bürk uploaded patch set 2 03/27/22, 18:52

  5. core-ci voted on patch set 2 V +1 03/27/22, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25189

  6. Stefan Bürk commented on patch set 2 03/27/22, 19:01

    composer.json:24 Reply

    Done
  7. Benni Mack voted on patch set 2 V +1 CR +1 03/27/22, 19:08

  8. Oliver Klee voted on patch set 2 CR +1 03/27/22, 19:21

  9. Stefan Bürk voted on patch set 2 V +1 CR +1 03/27/22, 19:59

  10. Benni Mack voted on patch set 2 V +2 CR +2 03/27/22, 20:25

  11. Benni Mack merged patch set 3 03/27/22, 20:25