Review main Merged

74066[TASK] Inform about not found user in record history

Oli Bartsch CR +2 V +2 Easy +8 −2 updated 03/28/22, 10:55

Commit message

When a user is no longer available (e.g. deleted),
record history entries for this user were not clear
since only the general avatar without a name was
displayed. This was especially confusing in case
the "(via XYZ)" string was displayed, which happens
if the change was done in switch user mode.

This is improved by using the "[Not found]" label.

Additionally, it now also ensures the "(via XYZ)"
information is kept, in case the corresponding user
is no longer available.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Oli Bartsch uploaded patch set 1 03/28/22, 08:59

  2. core-ci voted on patch set 1 V +1 03/28/22, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25203

  3. Oli Bartsch uploaded patch set 2 03/28/22, 09:18

  4. Oli Bartsch uploaded patch set 3 03/28/22, 09:19

  5. core-ci voted on patch set 2 V +1 03/28/22, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25204

  6. Stefan Bürk voted on patch set 3 V +1 CR +1 03/28/22, 09:29

  7. core-ci voted on patch set 3 V +1 03/28/22, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25205

  8. Benni Mack voted on patch set 3 V +1 CR +1 03/28/22, 10:02

  9. Oliver Klee voted on patch set 3 CR +1 03/28/22, 10:20

  10. Oli Bartsch voted on patch set 3 V +2 CR +2 03/28/22, 10:55

  11. Oli Bartsch merged patch set 4 03/28/22, 10:55