Review 11.5 Merged

74068[BUGFIX] Bring back functionality for $uniqueIds in SelectSingleElement

Christian Kuhn CR +2 V +2 Easy +8 −7 updated 03/28/22, 14:03

Commit message

This resolves a todo for a missing usage of a filled
array called "$uniqueIds".

This array had two responsibilities:

1. For inline fields with "foreign_unique" set, all
already used unique ids must be excluded from the
select items.

2. Ensure a select field inside an inline field,
which functions as one (symmetric) side of a
mn-table, will not have the same field we are
currently in, in its select items. In short: This
prevents self-references.

The previous functionality has been restored with
added type-safety.

This functionality was probably removed by accident
during a refactoring process.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1