Review 11.5 Merged

74124[BUGFIX] Allow backend layout without any colPos

Kevin Appelt CR +2 V +2 Easy +1 −1 updated 05/04/22, 15:05

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Kevin Appelt uploaded patch set 1 03/31/22, 10:54

  2. Simon Schaufelberger commented on patch set 1 03/31/22, 11:02

    please always target Releases: main, 11,5 otherwise it won't be in the upcoming version 12.
  3. Simon Schaufelberger wrote 03/31/22, 11:02

    Removed cc Simon Schaufelberger.
  4. core-ci voted on patch set 1 V -1 03/31/22, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25302

  5. Kevin Appelt commented on patch set 1 03/31/22, 11:08

    Reply

    I mentioned it in the issue: main branch is not affected by this issue. The code was changed in a breaking change for v12 and does not run into this issue.
  6. Oli Bartsch voted on patch set 1 V +1 CR +1 03/31/22, 11:17

  7. Oli Bartsch commented on patch set 1 V 0 CR 0 03/31/22, 11:23

    > Patch Set 1: Verified-1 > > Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25302 oke, phpstan seems to not understand that this variable might be NULL if not initialized. There are different possibilities to circumvent this. We could define an empty string as default value or we could remove the "if (!empty($backendLayout->getColumnPositionNumbers())) {" check and always set $this->colPosList.
  8. Oli Bartsch uploaded patch set 2 05/04/22, 14:41

  9. core-ci voted on patch set 2 V +1 05/04/22, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26828

  10. Oli Bartsch voted on patch set 2 V +1 CR +1 05/04/22, 14:55

  11. Stefan Bürk voted on patch set 2 V +2 CR +2 05/04/22, 15:04

  12. Stefan Bürk merged patch set 3 05/04/22, 15:05