Review main Merged

74125[BUGFIX] Add guard clause to prevent Link Browser from fataling

Jan Helke CR +2 V +2 Easy +1 −1 updated 03/31/22, 13:35

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Jan Helke uploaded patch set 1 03/31/22, 12:18

  2. core-ci voted on patch set 1 V +1 03/31/22, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25303

  3. Stefan Bürk commented on patch set 1 03/31/22, 12:37

    BrowseLinksController.php:147

    This does not make much sense. Would suggest to use here following: ``` if (is_array($this->thisConfig['classesAnchor'] ?? null)) { ``` Otherwise, an empty array would not go in this code block, which would be a change in behaviour. And this will ensure that the array key exists(which is eventually the failing one) which has been tried to cover with magic empty().
  4. Jan Helke uploaded patch set 2 03/31/22, 12:52

  5. Jan Helke commented on patch set 2 03/31/22, 12:54

    BrowseLinksController.php:147 Reply

    Fine with me
  6. core-ci voted on patch set 2 V +1 03/31/22, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25305

  7. Stefan Bürk commented on patch set 2 V +1 CR +1 03/31/22, 13:05

    BrowseLinksController.php:147 Reply

    Done
  8. Oli Bartsch voted on patch set 2 V +2 CR +2 03/31/22, 13:35

  9. Oli Bartsch merged patch set 3 03/31/22, 13:35