74156[FEATURE] Forward console command output when executed via scheduler
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97282-ForwardCommandOutputWhenExecutedViaSchedulerInCLIContext.rstnew+28 −0
- typo3/sysext/scheduler/Classes/Command/SchedulerCommand.php+9 −2
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandTask.php+25 −4
- typo3/sysext/scheduler/Classes/OutputAwareInterface.phpnew+29 −0
- typo3/sysext/scheduler/Classes/Scheduler.php+20 −0
Review log 1115
-
Elias Häußler uploaded patch set 1 04/01/22, 14:27
-
core-ci voted on patch set 1 V -1 04/01/22, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25358
-
Elias Häußler uploaded patch set 2 04/01/22, 14:52
-
core-ci voted on patch set 2 V +1 04/01/22, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25359
-
Elias Häußler uploaded patch set 3 07/01/22, 14:53
-
Elias Häußler uploaded patch set 4 07/01/22, 15:00
-
core-ci voted on patch set 3 V -1 07/01/22, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28581
-
core-ci voted on patch set 4 V +1 07/01/22, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28583
-
Christian Kuhn commented on patch set 4 07/01/22, 18:55
This somehow feels fishy: We have cli-commands. We have a scheduler task to register cli-commands as scheduler task. we have a cli-command to run registered scheduler-commands. It turns out, output of such scheduler-registered-cli-commands do not properly output on cli. And that't what the patch is about. Does anyone else find this construct confusing? When i refactored the scheduler main controller some month ago, i realized this distinction between cli command and scheduler task does not make that much sense. I had some ideas on that, but didn't realize them, but my main idea was 'make them the same, drop the distinction, somehow'. To solve this, the patch now needs a new interface wired into scheduler to manage this state. It does what is needed to solve the above combination and is the way to go if we keep the current construct. But the construct feels wrong. As such, I'm reluctant / skeptical if we should follow this patch, or if we should maybe rather think about the scheduler / cli distinction and if we maybe couldn't rethink this area instead to solve this issue as a side-effect. -
Oliver Klee commented on patch set 4 07/16/23, 11:11
How should we continue here? -
Oliver Klee wrote 08/25/24, 10:13
Removed cc Oliver Klee. -
Garvin Hicking commented on patch set 4 09/05/24, 15:57
Ideally I would like this to become obsolete with https://review.typo3.org/c/Packages/TYPO3.CMS/+/74053 (which is currently blocked by site settings API). But I'll put it on my agenda to move this forward after feature freeze, and depending on the scope of the addition of CLI commands from tasks we could also regard this as a task, not a feature. What do you think about this aim? -
Elias Häußler commented on patch set 4 09/09/24, 05:55
Reply
Sounds good to me, @gh@faktor-e.de 👍 Should I leave this patch open for the time being or is it time to abandon it? :) -
Garvin Hicking commented on patch set 4 09/09/24, 06:47
Reply
Great, thanks for the feedback :) I've now related the two issues on forge. IMO abandoning this one for cleanup would be good; if we need it after all, we could restore that at any time :) -
Elias Häußler abandoned the change 09/09/24, 07:00
Abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/74053