Review main Merged

74157[BUGFIX] Align functional splitting to chunk execution

Stefan Bürk CR +2 V +2 Easy +6 −2 updated 04/06/22, 08:39

Commit message

The check for doing the functional test splitting
script and running the selected chunk used similar
but different minimum chunk value to check against.
Thus the splitting script has not been executed in
all chunk execution contexts.

This patch uses now exactly the same check in the
'Build/Scripts/runTests.sh' like it is defined in
the corresponding docker-compose service config.

Furthermore all previous created functional split
files are now removed to avoid leftovers, which
occured if re-run has lower chunksize defined.

Example which is now properly fixed:

> Build/Scripts/runTests.sh -s functional -c 1/1

Example with partial part files from previous run:

> Build/Scripts/runTests.sh -s functional -c 1/10
> Build/Scripts/runTests.sh -s functional -c 1/8

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. Stefan Bürk uploaded patch set 1 04/01/22, 17:31

  2. Stefan Bürk uploaded patch set 2 04/01/22, 17:37

  3. core-ci voted on patch set 1 V +1 04/01/22, 17:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25360

  4. core-ci voted on patch set 2 V +1 04/01/22, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25361

  5. Stefan Bürk updated the commit message in patch set 3 04/01/22, 17:55

  6. Stefan Bürk commented on patch set 3 04/01/22, 17:57

    Backports applies on 11.5 and 10.4, but 10.4. needs a small adjustment - which is added as comment to the corresponding line.

    docker-compose.yml:774

    Backport 10.4 must here be changed to: ``` rm -rf Build/FunctionalTests-Job-*.xml ```
  7. core-ci voted on patch set 3 V +1 04/01/22, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25362

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 04/04/22, 17:31

  9. Christian Kuhn commented on patch set 3 04/04/22, 17:35

    docker-compose.yml:774 Reply

    will do during backport.
  10. Oli Bartsch voted on patch set 3 V +1 CR +1 04/05/22, 13:09

  11. Andreas Kienast voted on patch set 3 CR +1 04/05/22, 13:27

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 04/06/22, 08:39

  13. Christian Kuhn merged patch set 4 04/06/22, 08:39