Review main Merged

74163[TASK] Use bootstrap badges instead of labels

Benjamin Kott CR +2 V +2 Hard +250 −309 updated 04/05/22, 14:08

Commit message

The "label" class was removed in bootstrap 5 and replaced through
"badge". The "label" class was kept in place for a while to keep
the compatibility as high as possible, but it's time to move on.

Since bootstrap 5 also dropped support for severities on certain
components, we are adding them again for the badge to keep the
convenience as high as possible and avoid promoting the "utility css"
approach that was introduced with these decisions as we try to keep
markup changes as low as possible.

This patch also reverts the SCSS includes back to relative paths.

While it is possible to define additional lookup paths for the parser,
so you can have shorter includes - it comes at a cost. The included
sources are opaque to the user and the IDE, this means there is
no support for auto-completion, quick navigation through included files
and can lead to unintended overrides by the user.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 51

Show 31 more files