Review main Merged Breaking

74165[!!!][TASK] Migrate backend modal component to lit

Benjamin Franzke CR +2 V +2 Expert +1030 −822 updated 09/08/22, 15:28

Commit message

Avoid jQuery and especially the bootstrap
jQuery compat layer.
Use lit as template engine instead of jQuery composition
and avoid the bootstrap jQuery compat layer for initialization.

Will allow lit's TemplateResult to be directly passed
to the modal as content, allowing for a secure and
straight forward templating system for the modal API.

Left for another patch is the migration of
AbstractInteractableModule away from jQuery
and the adaption of login-refresh.ts to use
the TYPO3 Modal api, instead of directly calling
into bootstraps jQuery-Modal API.

Support for jQuery based modal content is kept for
now, as it doesn't require us to load jQuery
proactively and may ease migration for some users,
but lit TemplateResults are suggested to be used
instead. The jQuery content support may be
deprecated in an upcoming sprint release.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 100

Show 80 more files