Review main Merged

74169[BUGFIX] Remove Symfony polyfill replacements from core

Helmut Hummel CR +2 V +2 Easy +0 −9 updated 04/07/22, 11:30

Commit message

Adding a replace to a package semantically means, that
this package replaces another one. This is not true
for typo3/cms-core and therefore the replacement should
not be declared.

Additionally, composer fails when more than one dependency
declare identical replaces. We thus can not declare them
in typo3/cms-core since it would conflict as soon as any
other dependency does that, too.

It is fine for typo3/cms as this only serves as base for
a bundled build for non Composer installations and for
development. As such, the replacements are kept in
monorepo root composer.json.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1