Review main Merged

74170[TASK] Comment two symfony/rate-limiter related tests

Christian Kuhn CR +2 V +2 Easy +6 −0 updated 04/04/22, 19:40

Commit message

symfony/rate-limiter:5.4.7 has a bug [1] leading to
E_DEPRECATED warnings in our functional rate limiting
tests. This is mostly test related so it does not
make much sense to set this version as conflict.

We'll comment two tests while waiting for a patch
level release 5.4.8.

[1] https://github.com/symfony/symfony/issues/45924

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 04/04/22, 17:20

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 04/04/22, 17:21

  3. Stefan Bürk commented on patch set 1 CR -1 04/04/22, 17:23

    running nightly next to pre-merge on it: https://git.typo3.org/typo3/CI/cms/-/pipelines/25451
  4. core-ci voted on patch set 1 V +1 04/04/22, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25449

  5. core-ci commented on patch set 1 04/04/22, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25451

  6. Stefan Bürk voted on patch set 1 CR +1 04/04/22, 17:52

  7. Oli Bartsch voted on patch set 1 V +1 CR +1 04/04/22, 18:15

  8. Georg Ringer voted on patch set 1 V +2 CR +2 04/04/22, 19:40

  9. Georg Ringer merged patch set 2 04/04/22, 19:40