Review main Merged

74174[BUGFIX] Handle flexform in BU::getProcessedValue() only if not null

Andreas Kienast CR +2 V +2 Normal +75 −23 updated 04/06/22, 12:49

Commit message

The contents of a field of type `flex` may be NULL if the field is
empty. `BackendUtility::getProcessedValue()` handles the content of such
`flex` fields now only if the value is an actual string to solve
deprecations related to PHP 8.1.

In the same run, the content is trimmed to get rid of lots of empty
lines caused by multiline XML data.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1822

  1. Andreas Kienast uploaded patch set 1 04/05/22, 07:27

  2. core-ci voted on patch set 1 V -1 04/05/22, 07:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25470

  3. Xavier Perseguers voted on patch set 1 V +1 CR +1 04/05/22, 08:04

  4. Oliver Klee commented on patch set 1 04/05/22, 08:38

    BackendUtility.php:1686

    If it's a string, we don't need the cast anymore.
  5. Andreas Kienast commented on patch set 1 CR -1 04/05/22, 10:58

  6. Andreas Kienast commented on patch set 1 04/05/22, 10:58

    BackendUtility.php:1686 Reply

    Ack, I forgot to remove that
  7. Andreas Kienast uploaded patch set 2 04/05/22, 16:13

  8. core-ci voted on patch set 2 V -1 04/05/22, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25538

  9. Andreas Kienast uploaded patch set 3 04/05/22, 16:46

  10. Oliver Klee voted on patch set 3 CR +1 04/05/22, 16:52

  11. core-ci voted on patch set 3 V +1 04/05/22, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25545

  12. Markus Klein voted on patch set 3 CR +1 04/05/22, 18:12

  13. Oli Bartsch commented on patch set 3 04/05/22, 18:53

    BackendUtility.php:1612

    Should we adjust this @todo?

    BackendUtility.php:1673

    Should we adjust this @todos?
  14. Susi Moog voted on patch set 3 V +1 CR +1 04/06/22, 07:26

  15. Andreas Kienast commented on patch set 3 CR -1 04/06/22, 10:07

    on it

    BackendUtility.php:1612 Reply

    I'd remove the phpstan part, the "appropriate check" remark is still valid
  16. Andreas Kienast commented on patch set 3 04/06/22, 10:08

    BackendUtility.php:1686 Reply

    Done
  17. Andreas Kienast uploaded patch set 4 04/06/22, 10:08

  18. core-ci voted on patch set 4 V +1 04/06/22, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25612

  19. Oli Bartsch commented on patch set 4 V +1 CR +1 04/06/22, 10:29

    BackendUtility.php:1612 Reply

    Done

    BackendUtility.php:1673 Reply

    Done
  20. Susi Moog voted on patch set 4 V +1 CR +1 04/06/22, 12:49

  21. Andreas Kienast voted on patch set 4 V +2 CR +2 04/06/22, 12:49

  22. Andreas Kienast merged patch set 5 04/06/22, 12:49