Review main Merged

74177[BUGFIX] Explicitly use control characters in HTML fixture

Andreas Kienast CR +2 V +2 Hard +195 −196 updated 04/05/22, 15:09

Commit message

`RenderPreviewImportPageAndRecordsByUpdateWithDiff.php` has HTML markup
with line breaks and tab characters. With some IDEs this may break if
lines containing a tab only will get trimmed. All such characters are
now replaced by explicit control characters to make sure the expectation
does not break anymore when saving this file.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Simon Gilli +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Simon Gilli +1
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1014

  1. Andreas Kienast uploaded patch set 1 04/05/22, 10:53

  2. Andreas Kienast uploaded patch set 2 04/05/22, 10:55

  3. Andreas Kienast updated the commit message in patch set 3 04/05/22, 10:57

  4. Oliver Klee voted on patch set 3 CR +1 04/05/22, 11:14

  5. Christian Kuhn rebased onto patch set 4 04/05/22, 11:17

  6. Simon Gilli voted on patch set 4 CR +1 04/05/22, 11:36

  7. core-ci voted on patch set 4 V +1 04/05/22, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25495

  8. core-ci voted on patch set 3 V +1 04/05/22, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25497

  9. core-ci voted on patch set 1 V -1 04/05/22, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25499

  10. Simon Gilli voted on patch set 4 V +1 04/05/22, 12:43

  11. core-ci voted on patch set 2 V +1 04/05/22, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25498

  12. Frank Nägler voted on patch set 4 V +1 CR +1 04/05/22, 15:06

  13. Andreas Kienast voted on patch set 4 V +2 CR +2 04/05/22, 15:09

  14. Andreas Kienast merged patch set 5 04/05/22, 15:09