Review main Merged

74203[TASK] Polish SvgTree component styling

Benjamin Kott CR +2 V +2 Hard +426 −315 updated 05/06/22, 14:37

Commit message

This patch is cleaning up a lot of loose ends in the svg tree component.
It aims to make the component look more clean and polished.

- Unify focus styling with selected, hover and versioning
- Ensure the whole node looks focused instead of only some text
- Replace expand icon to match core icon styling
- Hide expand icon if page tree is stopped
- Move trigger to enter stopped pagetree to the front
- Remove blurry lines for background borders
- Make the edit input fields use as much space as is available
- Load common icons always on setup to avoid node refresh on initial loads
- Reposition the locked icon (another editor is editing)
- Correct keyboard navigation behaviour and focus setting
- Keep focus after leaving the edit mode without changes
- Adjust positioning to rely on calculation instead of hardcoded values
- Align drag delete target
- Make drag positions more visible to the user when moving a page
- Improve styling of tooltips when dragging elements
- Add border to select tree component to make scroll boundaries visible

Affected Areas:
- PageTree
- FileTree
- SelectTree

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 24

Show 4 more files