Review main Merged

74218[BUGFIX] Check for undefined fileTarget

Georg Ringer CR +2 V +2 Easy +2 −3 updated 04/07/22, 22:59

Commit message

Check if the fileTarget is set before using it.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1315

  1. Georg Ringer uploaded patch set 1 04/07/22, 13:20

  2. Georg Ringer commented on patch set 1 04/07/22, 13:20

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 04/07/22, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25749

  4. Preben Sørensen voted on patch set 1 V +1 CR +1 04/07/22, 13:35

  5. Benni Mack voted on patch set 1 V +1 CR +1 04/07/22, 21:02

  6. Stefan Bürk voted on patch set 1 V +1 CR +1 04/07/22, 21:21

  7. Oli Bartsch commented on patch set 1 04/07/22, 21:39

    SearchController.php:488

    No blocker, but this was previously only done after some conditions were met. Now this is always done, even if never used. IMO we should either fix it at both places separately or maybe move this to an own method, which is then called at those places.
  8. Stefan Bürk commented on patch set 1 04/07/22, 22:18

    SearchController.php:488 Reply

    Sure, original it has been processed two times, directly for each usage (two times). Preparing it above once and use it on the two places, as it is not that "expensive". Preparing the target is in no way bound to the additional conditions. That's way I was fine with combining and moving the preparation up in one place. Not sure about a dedicated method for it - not clear enough on the side "yes, absolutly". And if it would make that much sense as a dedicated method.
  9. Oli Bartsch commented on patch set 1 04/07/22, 22:26

    SearchController.php:488 Reply

    What I mean, now it is *always* prepared, no matter if it is actually used (depending on if the conditions are met). Sure it previously might have been prepared two times, but only if both conditions were met.
  10. Stefan Bürk uploaded patch set 2 04/07/22, 22:38

  11. Stefan Bürk commented on patch set 2 V +1 CR +1 04/07/22, 22:39

    SearchController.php:488 Reply

    Done.
  12. Oli Bartsch voted on patch set 2 V +1 CR +1 04/07/22, 22:42

  13. core-ci voted on patch set 2 V +1 04/07/22, 22:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25800

  14. Oli Bartsch voted on patch set 2 V +2 CR +2 04/07/22, 22:59

  15. Oli Bartsch merged patch set 3 04/07/22, 22:59