Review main Merged

74223[TASK] Simplify info boxes in page module

Georg Ringer CR +2 V +2 Easy +2 −8 updated 04/08/22, 09:35

Commit message

Info boxes are shown in the page module for pages like
"link to external url" or "Shortcut" if a relevant field
is not filled. The current page title doesn't help at all
and is shown below anyway. Therefore it can be removed.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. Georg Ringer uploaded patch set 1 04/07/22, 17:56

  2. Georg Ringer commented on patch set 1 04/07/22, 17:56

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 04/07/22, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25785

  4. Benjamin Franzke wrote 04/07/22, 18:19

    Topic set to ui
  5. Benjamin Franzke voted on patch set 1 V +1 CR +1 04/07/22, 18:19

  6. Oli Bartsch commented on patch set 1 04/07/22, 20:32

    PageLayoutController.php:389

    This is now the only case, the title is kept. However, I think it can be remove here as well since it is already present in then link text.
  7. Stefan Bürk updated the commit message in patch set 2 04/07/22, 22:42

  8. core-ci voted on patch set 2 V +1 04/07/22, 22:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25801

  9. Georg Ringer uploaded patch set 3 04/08/22, 09:15

  10. core-ci voted on patch set 3 V +1 04/08/22, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25820

  11. Oli Bartsch commented on patch set 3 V +1 CR +1 04/08/22, 09:34

    PageLayoutController.php:389 Reply

    Done
  12. Benjamin Franzke voted on patch set 3 V +2 CR +2 04/08/22, 09:34

  13. Benjamin Franzke merged patch set 4 04/08/22, 09:35