Review 11.5 Merged

74230[BUGFIX] Avoid race conditions in pagetree contextmenu actions

Andreas Kienast CR +2 V +2 Easy +6 −18 updated 04/08/22, 08:44

Commit message

All pagetree actions that use the "RecordCommit" endpoint (tce_db)
(which is loaded in to the main list_frame) need to avoid requesting
an explicit and too early page tree update from the server, as the
page data may not have been updated at that point. The pagetree refresh
actually is and needs to be triggered by an immediate action pushed by
the RecordCommit endpoint.
(in the list frame via <typo3-immediate-action> element)

An early-refresh call – prior to the persistence of the record
action – causes stale data to be fetched and displayed when that
request ends up to be processed after the record commit request
(that is the "race" that causes this to only happen sometimes).
Example: Page icon sometimes doesn't change on deactivation.

Affected page tree actions are:
 * disable/enable page
 * hide/show in menu
 * past into/after

Note that these actions should ideally be migrated
to AjaxDataHandler. Once that's done, the pagetree
refresh can be added back.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2